Skip to content

Conversation

@johansolbakken
Copy link
Contributor

@johansolbakken johansolbakken commented Dec 3, 2025

  • Working towards rendering JSON using the data disclosure API.
  • Many of the components that are to be rendered expose their state using the inspector interface.
  • This PR makes Inspector implement DataSource.
  • The inspector interface has a default implementation for emit that prefers UTF-16 for strings.
  • Subclasses can override emit to provide UTF-8 and UTF-16 directly for better performance.
  • Since the inspector is a part of data access, it makes sense for it to implement a data source.

@andreer please review
@havardpe please review

@andreer andreer force-pushed the johsol/inspector-as-data-source branch from 6cac16d to 71c8ca4 Compare December 4, 2025 08:33
@johansolbakken johansolbakken force-pushed the johsol/inspector-as-data-source branch from d10e2cb to 8e94254 Compare December 4, 2025 12:18
@johansolbakken johansolbakken force-pushed the johsol/inspector-as-data-source branch from 8e94254 to 549b9ec Compare December 4, 2025 12:20
@andreer andreer marked this pull request as ready for review December 4, 2025 12:24
@andreer andreer merged commit 1228d84 into master Dec 4, 2025
3 checks passed
@andreer andreer deleted the johsol/inspector-as-data-source branch December 4, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants