Change address_version for P2SH

[prusnak]

Currently it is 5 like in Bitcoin making the P2SH addresses look the same (they start with 3). This is confusing for new people and will lead to coin loss. Lots of services use Segwit-in-P2SH as default, which is making the whole issue even worse.

I suggest to change this constant to something different which does not collide with other coins.

[metalicjames]

Whilst it would be great to do that, as you pointed out most services only understand the 3 prefixed addresses. Changing the default version byte to something else would mean older wallets would not understand them and require adding yet another address generation option to each wallet so users can still generate the old 3 prefixed P2SH addresses.

Do you not think a better long term solution would be to migrate everyone to P2WSH and P2WPKH addresses which use the bech32 vtc prefix and thus negate this problem entirely?

[prusnak]

Long term native-segwit solution is fine and I agree, but I still think that changing the P2SH version is a very good idea.