open_basedir restriction

[labby]

Hi there,
is it possible to override the tmp path to avoid acces violations caused by open_basedir restrictions?
Something like $this->handle->custom_path = 'my_new_temp_path';
This would help a lot.

[verot]

Which access violations? The class should be compatible with open_basedir restrictions (it copie sthe file in the destination directory, over which you should have permissions.

What is precisely your use case? When are the violations happening?

[labby]

this is obviously a special professional installation that throws error_code 6 if the temp directory is not allowed because the tmp_path is not in the "normal" /var/www/my_domain.tld

Hope it is written understandable...

[verot]

I see. I don't have time to do it now, but you may want to send a patch which I'll gladly merge.

[labby]

I surely will, but I need some help.
I had a quick look at weekend at the code.
Is function temp_dir() (around line 2714) a good place to hook in?

[verot]

No, temp_dir() is not used for that purpose. You should look in the code block from line 3320

[labby]

ok, i will give it a try....

[labby]

3320 image_manipulation?
Are you sure?

[verot]

https://github.com/verot/class.upload.php/blob/master/src/class.upload.php#L3320

// if we have an uploaded file, and if it is the first process, and if we can't access the file directly (open_basedir restriction)
// then we create a temp file that will be used as the source file in subsequent processes
// the third condition is there to check if the file is not accessible *directly* (it already has positively gone through is_uploaded_file(), so it exists)
if (!$this->no_upload_check && empty($this->file_src_temp) && !@file_exists($this->file_src_pathname)) {
    $this->log .= '- attempting to use a temp file:';
    $hash = md5($this->file_dst_name_body . rand(1, 1000));
    if (move_uploaded_file($this->file_src_pathname, $this->file_dst_path . $hash . (!empty($this->file_dst_name_ext) ? '.' . $this->file_dst_name_ext : ''))) {
        $this->file_src_pathname = $this->file_dst_path . $hash . (!empty($this->file_dst_name_ext) ? '.' . $this->file_dst_name_ext : '');
        $this->file_src_temp = $this->file_src_pathname;
        $this->log .= ' file created<br />';
        $this->log .= '&nbsp;&nbsp;&nbsp;&nbsp;temp file is: ' . $this->file_src_temp . '<br />';
    } else {
        $this->log .= ' failed<br />';
        $this->processed = false;
        $this->error = $this->translate('temp_file');
    }
}

[labby]

thanks