You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to this documentation on package.json, dependencies can be specified as "", although rare, it is used and is part of the spec.
When I produce a pruned version of a yarn.lock file, using 'turbo prune', the double quotes are omitted resulting in an invalid yarn.lock file which breaks the build.
** Steps to replicate **
At time of writing, (I've emailed him ;-) ) murmurhash3. has a dependencies on 'shipit-js' which has this in it's dependencies
The yarn.lock parser requires two tokens per line, so breaks when it encounters this, not with a particularly friend error message either!
I would appreciate if this could be fixed, I wouldn't want anyone else to go through this! It took me a while to figure out that it was Turbo as the source of the problem!
Additional information
turbo--version2.5.5Bugisalsoin2.5.4
Steps to reproduce - simpler
create a monorepo where one subpackage has a dependency on 'murmurhash3' , make a pruned lockfile with
turbo prune subproject --docker and use the out/yarn.lock and yarn install with it. You will get an obtuse error message about a syntax error, which changes depending on which version of yarn you are using.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
Background
According to this documentation on package.json, dependencies can be specified as "", although rare, it is used and is part of the spec.
When I produce a pruned version of a yarn.lock file, using 'turbo prune', the double quotes are omitted resulting in an invalid yarn.lock file which breaks the build.
** Steps to replicate **
At time of writing, (I've emailed him ;-) ) murmurhash3. has a dependencies on 'shipit-js' which has this in it's dependencies
In the root lock file this becomes:
The pruned
yarn.lockproduced byturbo pruneis as follows:The yarn.lock parser requires two tokens per line, so breaks when it encounters this, not with a particularly friend error message either!
I would appreciate if this could be fixed, I wouldn't want anyone else to go through this! It took me a while to figure out that it was Turbo as the source of the problem!
Additional information
Steps to reproduce - simpler
create a monorepo where one subpackage has a dependency on 'murmurhash3' , make a pruned lockfile with
turbo prune subproject --dockerand use the out/yarn.lock andyarn installwith it. You will get an obtuse error message about a syntax error, which changes depending on which version of yarn you are using.Beta Was this translation helpful? Give feedback.
All reactions