replace prettier and ESLint with biome (#889)

* replace eslint and prettier with biome

* rm unused directives

* Update packages/blob/jest/setup.js

Co-authored-by: Andy <[email protected]>

* Update test/next/package.json

Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>

* fix lint/check

* ensure turbo can be used when checking

* rm @vercel/style-guide

---------

Co-authored-by: Andy <[email protected]>
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>

Author: 3 people

.eslintrc.js

@@ -13,8 +13,8 @@ on:
     branches: [main]
 
 jobs:
-  prettier:
-    name: 'Prettier'
+  biome:
+    name: "Biome"
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -25,38 +25,17 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version-file: '.node-version'
-          cache: 'pnpm'
+          node-version-file: ".node-version"
+          cache: "pnpm"
 
       - name: Install dependencies
         run: pnpm install
 
-      - name: Run Prettier check
-        run: pnpm prettier-check
-
-  eslint:
-    name: 'ESLint'
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Setup pnpm
-        uses: pnpm/action-setup@v2
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: '.node-version'
-          cache: 'pnpm'
-
-      - name: Install dependencies
-        run: pnpm install
-
-      - name: Run ESLint
-        run: pnpm run lint
+      - name: Run Biome Check
+        run: pnpm check
 
   types:
-    name: 'TypeScript'
+    name: "TypeScript"
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -67,8 +46,8 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version-file: '.node-version'
-          cache: 'pnpm'
+          node-version-file: ".node-version"
+          cache: "pnpm"
 
       - name: Install dependencies
         run: pnpm install
@@ -77,7 +56,7 @@ jobs:
         run: pnpm run type-check
 
   publint:
-    name: 'publint'
+    name: "publint"
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -88,8 +67,8 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version-file: '.node-version'
-          cache: 'pnpm'
+          node-version-file: ".node-version"
+          cache: "pnpm"
 
       - name: Install dependencies
         run: pnpm install

.github/workflows/quality.yml

@@ -0,0 +1,49 @@
+{
+  "$schema": "https://biomejs.dev/schemas/2.2.7/schema.json",
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "useIgnoreFile": true
+  },
+  "files": {
+    "ignoreUnknown": false
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space"
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "correctness": {
+        "noUnusedFunctionParameters": "off",
+        "useUniqueElementIds": "off"
+      },
+      "complexity": {
+        "noUselessSwitchCase": "off"
+      },
+      "suspicious": {
+        "noExplicitAny": "off",
+        "noArrayIndexKey": "off",
+        "noUnknownAtRules": "off"
+      },
+      "a11y": {
+        "noSvgWithoutTitle": "off",
+        "useMediaCaption": "off"
+      },
+      "performance": {
+        "noImgElement": "off"
+      },
+      "style": {
+        "useNodejsImportProtocol": "off",
+        "noNonNullAssertion": "off"
+      }
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "single"
+    }
+  }
+}

biome.json

@@ -11,10 +11,9 @@
   "scripts": {
     "build": "turbo build",
     "integration-test": "turbo integration-test",
-    "lint": "turbo lint -- --max-warnings=0",
+    "check": "turbo check",
     "prepare": "husky",
-    "prettier-check": "prettier --check .",
-    "prettier-fix": "prettier --write .",
+    "check:fix": "biome check --write .",
     "publint": "turbo publint",
     "release": "pnpm build && changeset publish",
     "run-integration": "pnpm -F vercel-storage-integration-test-suite dev",
@@ -23,20 +22,16 @@
     "version-packages": "changeset version && pnpm i --no-frozen-lockfile && git add ."
   },
   "lint-staged": {
-    "*": [
-      "prettier --ignore-unknown --write"
+    "*.{js,ts,cjs,mjs,d.cts,d.mts,jsx,tsx,json,jsonc}": [
+      "biome check --write --no-errors-on-unmatched"
     ]
   },
-  "prettier": "@vercel/style-guide/prettier",
   "devDependencies": {
+    "@biomejs/biome": "2.2.7",
     "@changesets/cli": "2.28.1",
-    "@vercel/style-guide": "5.2.0",
-    "eslint": "8.56.0",
-    "eslint-config-custom": "workspace:*",
     "husky": "9.1.7",
     "jest": "29.7.0",
     "lint-staged": "15.4.3",
-    "prettier": "3.5.2",
     "publint": "0.3.7",
     "ts-jest": "29.2.6",
     "turbo": "2.4.4",

package.json

@@ -2,7 +2,7 @@
 // but they are available everywhere else.
 // See https://stackoverflow.com/questions/68468203/why-am-i-getting-textencoder-is-not-defined-in-jest
 const { TextEncoder, TextDecoder } = require('node:util');
-// eslint-disable-next-line import/order -- On purpose to make requiring undici work
+// On purpose to make requiring undici work
 const { ReadableStream } = require('node:stream/web');
 
 Object.assign(global, { TextDecoder, TextEncoder, ReadableStream });

packages/blob/jest/setup.js

@@ -42,9 +42,8 @@
     "build": "tsup && pnpm run copy-shims",
     "copy-shims": "cp src/*-browser.js dist/",
     "dev": "pnpm run copy-shims && tsup --watch --clean=false",
-    "lint": "eslint --max-warnings=0 .",
+    "check": "biome check",
     "prepublishOnly": "pnpm run build",
-    "prettier-check": "prettier --check .",
     "publint": "npx publint",
     "test": "pnpm run test:node && pnpm run test:edge && pnpm run test:browser",
     "test:browser": "jest --env jsdom .browser.test.ts --setupFilesAfterEnv ./jest/setup.js",
@@ -72,8 +71,6 @@
     "@types/async-retry": "1.4.9",
     "@types/jest": "29.5.14",
     "@types/node": "22.13.5",
-    "eslint": "8.56.0",
-    "eslint-config-custom": "workspace:*",
     "jest": "29.7.0",
     "jest-environment-jsdom": "29.7.0",
     "ts-jest": "29.2.6",

packages/blob/package.json

@@ -1,12 +1,12 @@
 import undici from 'undici';
 import {
   BlobAccessError,
+  BlobContentTypeNotAllowedError,
   BlobNotFoundError,
   BlobServiceNotAvailable,
   BlobStoreNotFoundError,
   BlobStoreSuspendedError,
   BlobUnknownError,
-  BlobContentTypeNotAllowedError,
   requestApi,
 } from './api';
 import { BlobError } from './helpers';

packages/blob/src/api.node.test.ts

@@ -1,7 +1,7 @@
-import type { Response } from 'undici';
 import retry from 'async-retry';
-import isNetworkError from './is-network-error';
+import type { Response } from 'undici';
 import { debug } from './debug';
+import { DOMException } from './dom-exception';
 import type {
   BlobCommandOptions,
   BlobRequestInit,
@@ -13,8 +13,8 @@ import {
   getApiUrl,
   getTokenFromOptionsOrEnv,
 } from './helpers';
+import isNetworkError from './is-network-error';
 import { blobRequest } from './request';
-import { DOMException } from './dom-exception';
 
 // maximum pathname length is:
 // 1024 (provider limit) - 26 chars (vercel  internal suffixes) - 31 chars (blob `-randomId` suffix) = 967
@@ -209,18 +209,15 @@ async function getBlobError(
       error = new BlobAccessError();
       break;
     case 'content_type_not_allowed':
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- TS, be smarter
       error = new BlobContentTypeNotAllowedError(message!);
       break;
     case 'client_token_pathname_mismatch':
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- TS, be smarter
       error = new BlobPathnameMismatchError(message!);
       break;
     case 'client_token_expired':
       error = new BlobClientTokenExpiredError();
       break;
     case 'file_too_large':
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- TS, be smarter
       error = new BlobFileTooLargeError(message!);
       break;
     case 'not_found':

packages/blob/src/api.ts

@@ -13,23 +13,22 @@ type ByteUnitMap = {
   readonly [_K in ByteUnit]: number;
 };
 
-// eslint-disable-next-line prefer-named-capture-group -- fine
 const parseRegExp = /^((-|\+)?(\d+(?:\.\d+)?)) *(kb|mb|gb|tb|pb)$/i;
 
 const map: ByteUnitMap = {
   b: 1,
-  // eslint-disable-next-line no-bitwise -- fine
+
   kb: 1 << 10,
-  // eslint-disable-next-line no-bitwise -- fine
+
   mb: 1 << 20,
-  // eslint-disable-next-line no-bitwise -- fine
+
   gb: 1 << 30,
-  tb: Math.pow(1024, 4),
-  pb: Math.pow(1024, 5),
+  tb: 1024 ** 4,
+  pb: 1024 ** 5,
 };
 
 export function bytes(val: string | number): number | null {
-  if (typeof val === 'number' && !isNaN(val)) {
+  if (typeof val === 'number' && !Number.isNaN(val)) {
     return val;
   }
   if (typeof val !== 'string') {
@@ -53,7 +52,7 @@ export function bytes(val: string | number): number | null {
     }
   }
 
-  if (isNaN(floatValue)) {
+  if (Number.isNaN(floatValue)) {
     return null;
   }
 

packages/blob/src/bytes.ts

@@ -2,10 +2,10 @@ import undici from 'undici';
 import {
   completeMultipartUpload,
   createMultipartUpload,
-  uploadPart,
-  upload,
   createMultipartUploader,
   put,
+  upload,
+  uploadPart,
 } from './client';
 
 describe('client', () => {