Turbopack: chore: Update anyhow, remove old backtrace feature (#85844)

- `anyhow` now causes `cargo clippy` to warn about `.to_string()` in `bail!(...)` calls. I also inlined most of these format string variables while I was at it. dtolnay/anyhow#426
- The `backtrace` feature isn't needed (and is a no-op) since Rust 1.65. https://github.com/dtolnay/anyhow/blob/master/Cargo.toml#L19-L22

Author: bgw

Cargo.lock

@@ -371,7 +371,7 @@ tungstenite = "0.20.1"
 allsorts = { version = "0.14.0", default-features = false, features = [
   "flate2_rust",
 ] }
-anyhow = "1.0.98"
+anyhow = "1.0.100"
 async-compression = { version = "0.3.13", default-features = false, features = [
   "gzip",
   "tokio",

Cargo.toml

@@ -13,7 +13,7 @@ bench = false
 workspace = true
 
 [dependencies]
-anyhow = { workspace = true, features = ["backtrace"] }
+anyhow = { workspace = true }
 byteorder = { workspace = true }
 either = { workspace = true }
 futures = { workspace = true }

crates/next-api/Cargo.toml

@@ -1533,10 +1533,8 @@ pub async fn rebase(
         let base_path = [&old_base.path, "/"].concat();
         if !fs_path.path.starts_with(&base_path) {
             bail!(
-                "rebasing {} from {} onto {} doesn't work because it's not part of the source path",
-                fs_path.to_string(),
-                old_base.to_string(),
-                new_base.to_string()
+                "rebasing {fs_path} from {old_base} onto {new_base} doesn't work because it's not \
+                 part of the source path",
             );
         }
         if new_base.path.is_empty() {

turbopack/crates/turbo-tasks-fs/src/lib.rs

@@ -124,7 +124,7 @@ async fn resolve_symlink_safely(entry: DirectoryEntry) -> Result<DirectoryEntry>
         if source_path.is_inside_or_equal(&resolved_entry.clone().path().unwrap()) {
             bail!(
                 "'{}' is a symlink causes that causes an infinite loop!",
-                source_path.path.to_string()
+                source_path.path,
             )
         }
     }

turbopack/crates/turbo-tasks-fs/src/read_glob.rs

@@ -17,7 +17,7 @@ harness = false
 workspace = true
 
 [dependencies]
-anyhow = { workspace = true, features = ["backtrace"] }
+anyhow = { workspace = true }
 chromiumoxide = { workspace = true, features = [
   "tokio-runtime",
 ], default-features = false }

turbopack/crates/turbopack-bench/Cargo.toml

@@ -84,11 +84,7 @@ impl EcmascriptBrowserChunkContent {
                 let chunk_server_path = if let Some(path) = output_root.get_path_to(&chunk_path) {
                     path
                 } else {
-                    bail!(
-                        "chunk path {} is not in output root {}",
-                        chunk_path.to_string(),
-                        output_root.to_string()
-                    );
+                    bail!("chunk path {chunk_path} is not in output root {output_root}");
                 };
                 Either::Left(StringifyJs(chunk_server_path))
             }

turbopack/crates/turbopack-browser/src/ecmascript/content.rs

@@ -99,11 +99,7 @@ impl EcmascriptBrowserEvaluateChunk {
                 let chunk_server_path = if let Some(path) = output_root.get_path_to(&chunk_path) {
                     path
                 } else {
-                    bail!(
-                        "chunk path {} is not in output root {}",
-                        chunk_path.to_string(),
-                        output_root.to_string()
-                    );
+                    bail!("chunk path {chunk_path} is not in output root {output_root}");
                 };
                 Either::Left(StringifyJs(chunk_server_path))
             }

turbopack/crates/turbopack-browser/src/ecmascript/evaluate/chunk.rs

@@ -27,11 +27,7 @@ impl EcmascriptBrowserChunkVersion {
         let chunk_path = if let Some(path) = output_root.get_path_to(&chunk_path) {
             path
         } else {
-            bail!(
-                "chunk path {} is not in client root {}",
-                chunk_path.to_string(),
-                output_root.to_string()
-            );
+            bail!("chunk path {chunk_path} is not in client root {output_root}");
         };
         let entries = EcmascriptBrowserChunkContentEntries::new(content).await?;
         let mut entries_hashes =

turbopack/crates/turbopack-browser/src/ecmascript/version.rs

@@ -37,7 +37,7 @@ custom_allocator = ["turbo-tasks-malloc/custom_allocator"]
 workspace = true
 
 [dependencies]
-anyhow = { workspace = true, features = ["backtrace"] }
+anyhow = { workspace = true }
 clap = { workspace = true, features = ["derive", "env"] }
 console-subscriber = { workspace = true, optional = true }
 dunce = { workspace = true }