test: replace deprecated check() with retry() in test suites

Refactor test files to use the retry() function with expect assertions
instead of the deprecated check() function. This change affects 206 test
files across the codebase and standardizes the test assertion pattern.

Author: wyattjoh

test/development/acceptance-app/ReactRefreshRegression.test.ts

@@ -2,7 +2,7 @@
 import { createSandbox } from 'development-sandbox'
 import { FileRef, nextTestSetup } from 'e2e-utils'
 import path from 'path'
-import { check } from 'next-test-utils'
+import { retry } from 'next-test-utils'
 import { outdent } from 'outdent'
 
 describe('ReactRefreshRegression app', () => {
@@ -174,17 +174,19 @@ describe('ReactRefreshRegression app', () => {
       `
     )
 
-    await check(
-      () => session.evaluate(() => document.querySelector('p').textContent),
-      '0'
-    )
+    await retry(async () => {
+      expect(
+        await session.evaluate(() => document.querySelector('p').textContent)
+      ).toBe('0')
+    })
 
     await session.evaluate(() => document.querySelector('button').click())
 
-    await check(
-      () => session.evaluate(() => document.querySelector('p').textContent),
-      '1'
-    )
+    await retry(async () => {
+      expect(
+        await session.evaluate(() => document.querySelector('p').textContent)
+      ).toBe('1')
+    })
 
     await session.patch(
       'index.js',
@@ -205,17 +207,19 @@ describe('ReactRefreshRegression app', () => {
       `
     )
 
-    await check(
-      () => session.evaluate(() => document.querySelector('p').textContent),
-      'Count: 1'
-    )
+    await retry(async () => {
+      expect(
+        await session.evaluate(() => document.querySelector('p').textContent)
+      ).toBe('Count: 1')
+    })
 
     await session.evaluate(() => document.querySelector('button').click())
 
-    await check(
-      () => session.evaluate(() => document.querySelector('p').textContent),
-      'Count: 2'
-    )
+    await retry(async () => {
+      expect(
+        await session.evaluate(() => document.querySelector('p').textContent)
+      ).toBe('Count: 2')
+    })
   })
 
   // https://github.com/vercel/next.js/issues/13978
@@ -256,10 +260,11 @@ describe('ReactRefreshRegression app', () => {
       `
     )
 
-    await check(
-      () => session.evaluate(() => document.querySelector('p').textContent),
-      '0'
-    )
+    await retry(async () => {
+      expect(
+        await session.evaluate(() => document.querySelector('p').textContent)
+      ).toBe('0')
+    })
 
     await session.evaluate(() => document.querySelector('button').click())
     expect(

test/development/acceptance-app/editor-links.test.ts

@@ -1,4 +1,4 @@
-import { check, retry } from 'next-test-utils'
+import { retry } from 'next-test-utils'
 import { FileRef, nextTestSetup } from 'e2e-utils'
 import path from 'path'
 import { createSandbox } from 'development-sandbox'
@@ -81,7 +81,9 @@ describe('Error overlay - editor links', () => {
 
     await session.assertHasRedbox()
     await clickSourceFile(browser)
-    await check(() => editorRequestsCount, /1/)
+    await retry(async () => {
+      expect(editorRequestsCount).toBe(1)
+    })
   })
   ;(process.env.IS_TURBOPACK_TEST ? describe.skip : describe)(
     'opening links in import traces',
@@ -124,7 +126,9 @@ describe('Error overlay - editor links', () => {
 
         await session.assertHasRedbox()
         await clickImportTraceFiles(browser)
-        await check(() => editorRequestsCount, /4/)
+        await retry(async () => {
+          expect(editorRequestsCount).toBe(4)
+        })
       })
 
       it('should be possible to open import trace files on module not found error', async () => {
@@ -165,7 +169,9 @@ describe('Error overlay - editor links', () => {
 
         await session.assertHasRedbox()
         await clickImportTraceFiles(browser)
-        await check(() => editorRequestsCount, /3/)
+        await retry(async () => {
+          expect(editorRequestsCount).toBe(3)
+        })
       })
     }
   )

test/development/acceptance-app/error-recovery.test.ts

@@ -1,7 +1,7 @@
 /* eslint-env jest */
 import { createSandbox } from 'development-sandbox'
 import { FileRef, nextTestSetup } from 'e2e-utils'
-import { check } from 'next-test-utils'
+import { retry } from 'next-test-utils'
 import path from 'path'
 import { outdent } from 'outdent'
 
@@ -118,10 +118,11 @@ describe('Error recovery app', () => {
 
     await session.assertNoRedbox()
 
-    await check(
-      () => session.evaluate(() => document.querySelector('p').textContent),
-      /Count: 1/
-    )
+    await retry(async () => {
+      expect(
+        await session.evaluate(() => document.querySelector('p').textContent)
+      ).toMatch(/Count: 1/)
+    })
   })
 
   test('server component can recover from syntax error', async () => {
@@ -181,10 +182,11 @@ describe('Error recovery app', () => {
         `
     )
 
-    await check(
-      () => session.evaluate(() => document.querySelector('p').textContent),
-      'Hello world 2'
-    )
+    await retry(async () => {
+      expect(
+        await session.evaluate(() => document.querySelector('p').textContent)
+      ).toBe('Hello world 2')
+    })
   })
 
   test('client component can recover from syntax error', async () => {
@@ -245,10 +247,11 @@ describe('Error recovery app', () => {
         `
     )
 
-    await check(
-      () => session.evaluate(() => document.querySelector('p').textContent),
-      'Hello world 2'
-    )
+    await retry(async () => {
+      expect(
+        await session.evaluate(() => document.querySelector('p').textContent)
+      ).toBe('Hello world 2')
+    })
   })
 
   test('can recover from a event handler error', async () => {

test/development/acceptance-app/server-components.test.ts

@@ -2,7 +2,7 @@
 import { createSandbox } from 'development-sandbox'
 import { FileRef, nextTestSetup } from 'e2e-utils'
 import path from 'path'
-import { check } from 'next-test-utils'
+import { retry } from 'next-test-utils'
 import { outdent } from 'outdent'
 
 describe('Error Overlay for server components', () => {
@@ -35,16 +35,15 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         expect(
           await browser
             .waitForElementByCss('#nextjs__container_errors_desc')
             .text()
         ).toContain(
           'createContext only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/context-in-server-component'
         )
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain(
         'createContext only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/context-in-server-component'
@@ -89,16 +88,15 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         expect(
           await browser
             .waitForElementByCss('#nextjs__container_errors_desc')
             .text()
         ).toContain(
           'createContext only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/context-in-server-component'
         )
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain(
         'createContext only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/context-in-server-component'
@@ -143,16 +141,15 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         expect(
           await browser
             .waitForElementByCss('#nextjs__container_errors_desc')
             .text()
         ).toContain(
           'createContext only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/context-in-server-component'
         )
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain(
         'createContext only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/context-in-server-component'
@@ -178,16 +175,15 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         expect(
           await browser
             .waitForElementByCss('#nextjs__container_errors_desc')
             .text()
         ).toContain(
           'useRef only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/react-client-hook-in-server-component'
         )
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain(
         'useRef only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/react-client-hook-in-server-component'
@@ -211,16 +207,15 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         expect(
           await browser
             .waitForElementByCss('#nextjs__container_errors_desc')
             .text()
         ).toContain(
           'experimental_useOptimistic only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/react-client-hook-in-server-component'
         )
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain(
         'experimental_useOptimistic only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/react-client-hook-in-server-component'
@@ -244,11 +239,10 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         const html = await browser.eval('document.documentElement.innerHTML')
         expect(html).toContain('experimental_useOptimistic')
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain('experimental_useOptimistic')
     })
@@ -288,16 +282,15 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         expect(
           await browser
             .waitForElementByCss('#nextjs__container_errors_desc')
             .text()
         ).toContain(
           'useState only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/react-client-hook-in-server-component'
         )
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain(
         'useState only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/react-client-hook-in-server-component'
@@ -339,16 +332,15 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         expect(
           await browser
             .waitForElementByCss('#nextjs__container_errors_desc')
             .text()
         ).toContain(
           'useEffect only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/react-client-hook-in-server-component'
         )
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain(
         'useEffect only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/react-client-hook-in-server-component'
@@ -375,16 +367,15 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         expect(
           await browser
             .waitForElementByCss('#nextjs__container_errors_desc')
             .text()
         ).toContain(
           'This might be caused by a React Class Component being rendered in a Server Component'
         )
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain(
         'This might be caused by a React Class Component being rendered in a Server Component'
@@ -427,16 +418,15 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         expect(
           await browser
             .waitForElementByCss('#nextjs__container_errors_desc')
             .text()
         ).toContain(
           'This might be caused by a React Class Component being rendered in a Server Component'
         )
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain(
         'This might be caused by a React Class Component being rendered in a Server Component'
@@ -479,16 +469,15 @@ describe('Error Overlay for server components', () => {
         ])
       )
       const { browser } = sandbox
-      await check(async () => {
+      await retry(async () => {
         expect(
           await browser
             .waitForElementByCss('#nextjs__container_errors_desc')
             .text()
         ).toContain(
           'This might be caused by a React Class Component being rendered in a Server Component'
         )
-        return 'success'
-      }, 'success')
+      })
 
       expect(next.cliOutput).toContain(
         'This might be caused by a React Class Component being rendered in a Server Component'