Improve DSQL interactions #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `@aws/aurora-dsql-node-postgres-connector` to simplify connection pool creation. - Speed up initial data load by inserting in batches which results in fewer roundtrips. This required node-pg-format. - Simplified the migrate script a bit by removing the use of `--> statement-breakpoint` - Added Prettier config - Some dependency upgrades to remove some of the warnings
|
@zakvdm is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
pkale
reviewed
Nov 25, 2025
| const now = new Date(); | ||
|
|
||
| if (pool && cachedToken && cachedToken.expiresAt > now) { | ||
| export async function getPool() { |
There was a problem hiding this comment.
For my understanding, are we generally leaning towards always having the agent use pools for creating a connection? Curious if it makes sense to leave the original method as a fallback or just provide more options if the agent runs into some error while trying to use a pooled connection.
pkale
reviewed
Nov 25, 2025
| pool = new Pool({ | ||
| pool = new AuroraDSQLPool({ | ||
| host: process.env.DB_CLUSTER_ENDPOINT!, | ||
| region: process.env.AWS_REGION || 'us-east-1', |
There was a problem hiding this comment.
How do we determine to use us-east-1 value as the default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
@aws/aurora-dsql-node-postgres-connectorto simplify connection pool creation.Speed up initial data load by inserting in batches which results in fewer roundtrips. This required node-pg-format.
Simplified the migrate script a bit by removing the use of
--> statement-breakpointAdded Prettier config
Some dependency upgrades to remove some of the warnings