Skip to content

Commit cdc5199

Browse files
committed
Drop Python 3.8 support
1 parent 21989de commit cdc5199

File tree

8 files changed

+31
-31
lines changed

8 files changed

+31
-31
lines changed

.github/workflows/docs.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ jobs:
2727
- name: Set up Python
2828
uses: actions/setup-python@v5
2929
with:
30-
python-version: '3.12'
31-
cache: 'pip'
32-
cache-dependency-path: '**/*requirements.txt'
30+
python-version: "3.12"
31+
cache: "pip"
32+
cache-dependency-path: "**/*requirements.txt"
3333

3434
- name: Install torch CPU-only version
3535
run: python -m pip install -r .github/torch_cpu_requirements.txt
@@ -82,7 +82,7 @@ jobs:
8282
runs-on: ubuntu-22.04
8383

8484
steps:
85-
- uses: re-actors/alls-green@release/v1
86-
with:
87-
allowed-skips: publish
88-
jobs: ${{ toJSON(needs) }}
85+
- uses: re-actors/alls-green@release/v1
86+
with:
87+
allowed-skips: publish
88+
jobs: ${{ toJSON(needs) }}

.github/workflows/lint.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
strategy:
1818
fail-fast: false
1919
matrix:
20-
python: ['3.8', '3.9', '3.10', '3.11', '3.12']
20+
python: ["3.9", "3.10", "3.11", "3.12"]
2121

2222
name: "Python ${{ matrix.python }}"
2323
runs-on: ubuntu-22.04
@@ -29,8 +29,8 @@ jobs:
2929
uses: actions/setup-python@v5
3030
with:
3131
python-version: ${{ matrix.python }}
32-
cache: 'pip'
33-
cache-dependency-path: '**/*requirements.txt'
32+
cache: "pip"
33+
cache-dependency-path: "**/*requirements.txt"
3434

3535
- name: Install torch CPU-only version
3636
run: python -m pip install -r .github/torch_cpu_requirements.txt
@@ -51,6 +51,6 @@ jobs:
5151
runs-on: ubuntu-22.04
5252

5353
steps:
54-
- uses: re-actors/alls-green@release/v1
55-
with:
56-
jobs: ${{ toJSON(needs) }}
54+
- uses: re-actors/alls-green@release/v1
55+
with:
56+
jobs: ${{ toJSON(needs) }}

.github/workflows/pypi.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
runs-on: ubuntu-22.04
8787

8888
steps:
89-
- uses: re-actors/alls-green@release/v1
90-
with:
91-
allowed-skips: publish-test, publish
92-
jobs: ${{ toJSON(needs) }}
89+
- uses: re-actors/alls-green@release/v1
90+
with:
91+
allowed-skips: publish-test, publish
92+
jobs: ${{ toJSON(needs) }}

.github/workflows/tests.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ jobs:
1717
strategy:
1818
fail-fast: false
1919
matrix:
20-
os: ['ubuntu-22.04', 'windows-2022']
21-
python: ['3.8', '3.9', '3.10', '3.11', '3.12']
20+
os: ["ubuntu-22.04", "windows-2022"]
21+
python: ["3.9", "3.10", "3.11", "3.12"]
2222

2323
name: "${{ matrix.os }} / Python ${{ matrix.python }}"
2424
runs-on: ${{ matrix.os }}
@@ -30,8 +30,8 @@ jobs:
3030
uses: actions/setup-python@v5
3131
with:
3232
python-version: ${{ matrix.python }}
33-
cache: 'pip'
34-
cache-dependency-path: '**/*requirements.txt'
33+
cache: "pip"
34+
cache-dependency-path: "**/*requirements.txt"
3535

3636
- name: Install torch CPU-only version
3737
run: python -m pip install -r .github/torch_cpu_requirements.txt
@@ -60,6 +60,6 @@ jobs:
6060
runs-on: ubuntu-22.04
6161

6262
steps:
63-
- uses: re-actors/alls-green@release/v1
64-
with:
65-
jobs: ${{ toJSON(needs) }}
63+
- uses: re-actors/alls-green@release/v1
64+
with:
65+
jobs: ${{ toJSON(needs) }}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ CharonLoad reduces the burden to start writing and experimenting with custom GPU
3838

3939
## Installation
4040

41-
CharonLoad requires **Python >=3.8** and can be installed from PyPI:
41+
CharonLoad requires **Python >=3.9** and can be installed from PyPI:
4242

4343
```sh
4444
pip install charonload

pyproject.toml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ version = "0.1.4"
44
authors = [{ name = "Patrick Stotko", email = "[email protected]" }]
55
description = "Develop C++/CUDA extensions with PyTorch like Python scripts"
66
readme = "README.md"
7-
requires-python = ">=3.8"
7+
requires-python = ">=3.9"
88
dependencies = [
99
"cmake>=3.27",
1010
'ninja ; platform_system != "Windows"',
@@ -21,7 +21,6 @@ classifiers = [
2121
"License :: OSI Approved :: MIT License",
2222
"Programming Language :: C++",
2323
"Programming Language :: Python :: 3 :: Only",
24-
"Programming Language :: Python :: 3.8",
2524
"Programming Language :: Python :: 3.9",
2625
"Programming Language :: Python :: 3.10",
2726
"Programming Language :: Python :: 3.11",
@@ -92,7 +91,7 @@ line-length = 120
9291
[tool.isort]
9392
profile = "black"
9493
multi_line_output = 3
95-
py_version = 38
94+
py_version = 39
9695

9796

9897
[tool.docformatter]

src/charonload/_runner.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,14 @@
1010
import subprocess
1111
import sys
1212
from abc import ABC, abstractmethod
13-
from typing import IO, TYPE_CHECKING, Iterable, Iterator, Literal
13+
from typing import IO, TYPE_CHECKING, Literal
1414

1515
import colorama
1616

1717
from ._errors import CommandNotFoundError
1818

1919
if TYPE_CHECKING: # pragma: no cover
20+
from collections.abc import Iterable, Iterator
2021
from types import TracebackType
2122

2223
from ._compat.typing import Self

src/charonload/_version.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from __future__ import annotations
22

33
import importlib.metadata
4-
from typing import Tuple, cast
4+
from typing import cast
55

66

77
def _version() -> str:
@@ -15,7 +15,7 @@ def _is_compatible(ver1: str, ver2: str) -> bool:
1515
def _str_to_tuple(ver: str) -> tuple[int, int, int]:
1616
components = list(map(int, ver.split(".")))
1717
components = [*components, 0, 0][:3]
18-
return cast(Tuple[int, int, int], tuple(components)) # typing.Tuple required for Python 3.8
18+
return cast(tuple[int, int, int], tuple(components))
1919

2020

2121
def _same_minor_version(ver1: tuple[int, int, int], ver2: tuple[int, int, int]) -> bool:

0 commit comments

Comments
 (0)