[DO NOT MERGE] Add heatmap panels for latency and throughput insights #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TTFB (Avg / p95): visualize client ↔ backend first-byte latency - TTLB (Avg / p95): show total end-to-end response times - Transfer Size (Bits/sec / p95): display traffic throughput and 95th-percentile payload sizes
guardalben
changed the title
Collaborator
|
any chance you can make the changes a bit more targeted? This PR changes a bunch of unrelated line (I think) |
Contributor
Author
|
Good point! this PR focus only on the dashboard part (varnish_metrics.json) changes. Unfortunately, the dashboard is self-contained inside of the provisioning folder. Not sure other way I can proposed changes and validate it here? This PR will make sense only when we have the otel 2.0 out and supported here. Then; we merge this one and the new metrics/dashboard will work just fine. But... I'm open for thoughts, ofc... |
Collaborator
|
we only want to support |
Contributor
Author
|
That's why a put DO NOT MERGE yet ;) waiting ... eheh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gquintard lets tweak the heatmaps here. As discussed, we need otel 2.0 with ttfb/ttlb support out before merge...
Dashboards contain insights on: