Adds payment status reversal for canceling accepted chargeback

Author: nanodirijabl

apps/hellgate/include/hg_invoice_payment.hrl

@@ -3,6 +3,7 @@
 
 -record(st, {
     activity :: hg_invoice_payment:activity(),
+    status_log = [] :: [dmsl_domain_thrift:'InvoicePaymentStatus'()],
     payment :: undefined | hg_invoice_payment:payment(),
     risk_score :: undefined | hg_inspector:risk_score(),
     routes = [] :: [hg_route:payment_route()],

apps/hellgate/src/hg_invoice_payment.erl

@@ -2239,6 +2239,17 @@ maybe_set_charged_back_status(?chargeback_status_accepted(), ChargebackBody, St)
         ?cash(Amount, _) when Amount > 0 ->
             []
     end;
+maybe_set_charged_back_status(
+    ?chargeback_status_cancelled(),
+    _ChargebackBody,
+    #st{
+        payment = #domain_InvoicePayment{status = ?charged_back()},
+        status_log = [_ActualStatus, PrevStatus | _]
+    }
+) ->
+    %% NOTE Mind warning (or constraint) of `invalid_transition` from
+    %% 'idle' activity.
+    [?payment_status_changed(PrevStatus)];
 maybe_set_charged_back_status(_ChargebackStatus, _ChargebackBody, _St) ->
     [].
 
@@ -3272,22 +3283,22 @@ merge_change(Change = ?payment_status_changed({failed, _} = Status), #st{payment
         St,
         Opts
     ),
-    St#st{
+    (record_status_change(Change, St))#st{
         payment = Payment#domain_InvoicePayment{status = Status},
         activity = idle,
         failure = undefined,
         timings = accrue_status_timing(failed, Opts, St)
     };
 merge_change(Change = ?payment_status_changed({cancelled, _} = Status), #st{payment = Payment} = St, Opts) ->
     _ = validate_transition({payment, finalizing_accounter}, Change, St, Opts),
-    St#st{
+    (record_status_change(Change, St))#st{
         payment = Payment#domain_InvoicePayment{status = Status},
         activity = idle,
         timings = accrue_status_timing(cancelled, Opts, St)
     };
 merge_change(Change = ?payment_status_changed({captured, Captured} = Status), #st{payment = Payment} = St, Opts) ->
-    _ = validate_transition({payment, finalizing_accounter}, Change, St, Opts),
-    St#st{
+    _ = validate_transition([idle, {payment, finalizing_accounter}], Change, St, Opts),
+    (record_status_change(Change, St))#st{
         payment = Payment#domain_InvoicePayment{
             status = Status,
             cost = get_captured_cost(Captured, Payment)
@@ -3298,19 +3309,19 @@ merge_change(Change = ?payment_status_changed({captured, Captured} = Status), #s
     };
 merge_change(Change = ?payment_status_changed({processed, _} = Status), #st{payment = Payment} = St, Opts) ->
     _ = validate_transition({payment, processing_accounter}, Change, St, Opts),
-    St#st{
+    (record_status_change(Change, St))#st{
         payment = Payment#domain_InvoicePayment{status = Status},
         activity = {payment, flow_waiting},
         timings = accrue_status_timing(processed, Opts, St)
     };
 merge_change(Change = ?payment_status_changed({refunded, _} = Status), #st{payment = Payment} = St, Opts) ->
     _ = validate_transition(idle, Change, St, Opts),
-    St#st{
+    (record_status_change(Change, St))#st{
         payment = Payment#domain_InvoicePayment{status = Status}
     };
 merge_change(Change = ?payment_status_changed({charged_back, _} = Status), #st{payment = Payment} = St, Opts) ->
     _ = validate_transition(idle, Change, St, Opts),
-    St#st{
+    (record_status_change(Change, St))#st{
         payment = Payment#domain_InvoicePayment{status = Status}
     };
 merge_change(Change = ?chargeback_ev(ID, Event), St, Opts) ->
@@ -3477,6 +3488,9 @@ merge_change(Change = ?session_ev(Target, Event), St = #st{activity = Activity},
             St2
     end.
 
+record_status_change(?payment_status_changed(Status), St) ->
+    St#st{status_log = [Status | St#st.status_log]}.
+
 latest_adjustment_id(#st{adjustments = []}) ->
     undefined;
 latest_adjustment_id(#st{adjustments = Adjustments}) ->

apps/hellgate/test/hg_invoice_tests_SUITE.erl

@@ -4097,10 +4097,9 @@ reopen_accepted_payment_chargeback_and_cancel_ok(C) ->
     [
         ?payment_ev(PID, ?chargeback_ev(CBID, ?chargeback_target_status_changed(?chargeback_status_cancelled()))),
         ?payment_ev(PID, ?chargeback_ev(CBID, ?chargeback_cash_flow_changed([]))),
-        ?payment_ev(PID, ?chargeback_ev(CBID, ?chargeback_status_changed(?chargeback_status_cancelled())))
-    ] = next_changes(IID, 3, Client),
-    %% TODO Implement status reversal and assert payment status is
-    %% prior the chargeback acceptance.
+        ?payment_ev(PID, ?chargeback_ev(CBID, ?chargeback_status_changed(?chargeback_status_cancelled()))),
+        ?payment_ev(PID, ?payment_status_changed(?captured()))
+    ] = next_changes(IID, 4, Client),
     ok.
 
 -spec reopen_payment_chargeback_inconsistent(config()) -> _ | no_return().