docs: Models > Records — Developer portal, quickstarts, & training#1328
Conversation
jamadriz
left a comment
There was a problem hiding this comment.
Blockers / should fix before merge
- Branch is behind main and would revert Starlark calculated-field docs
The branch is 1 commit behind main (likely #1323 — Calculated fields formula reference). Merging as-is would remove the Starlark helper table and guidance from site/guide/inventory/_field-types.qmd and roll examples back to params.materiality dot notation instead of params["materiality"].
main last touched that file: 99b05d4
PR branch last touched it: b91c76c (older records phase II work)
Action: Rebase or merge main into the branch and keep the Starlark content from #1323 while applying only the intentional record-type wording changes from this PR.
- Typo introduced in validation quickstart shared include
In _register-your-first-model.qmd, the validator path says recird owner instead of record owner:
_register-your-first-model.qmd
Lines 57-57
a. Select your own name under the [recird owner]{.smallcaps} drop-down — don't worry, we'll adjust these permissions next for validation.
The developer path correctly uses record owner. This typo was introduced in this PR’s diff.
- Lighthouse accessibility check failed
lighthouse failed with average accessibility 0.87 (threshold > 0.9). Other checks passed. Worth confirming whether new/changed pages introduced regressions or if this is a known baseline issue before merge.
|
@jamadriz ty for the review! Notes:
Up to date with main now (commit #9a92167), not sure what conflict it was talking about as it seems fine.
Fixed in commit #d57d216.
This is a known issue, Nik is working on it in #1333. |
Validate docs site✓ INFO: A live preview of the docs site is available — Open the preview |
Execute training notebooks for PRs✓ INFO: Live previews are available — |
Lighthouse check resultsShow Lighthouse scoresFolder depth level checked: 0 Commit SHA: 045c81a Modify the workflow to check a different depth:
|
…docs changes (#1350) * Document calculated field params dictionary including model_stage. Adds a reference table for built-in params keys on inventory and artifact calculation fields to close the documentation gap identified in sc-15239. * Restore Starlark calculated fields docs and add params dictionary. Re-applies the Calculation section from #1323, which was regressed by #1328, and inserts the params reference table above Available helpers for sc-15239. * Move params and helpers reference and turn into tabset
Pull Request Description
Warning
BECK REMOVE THE BRANCH REF TO THE RELEASE-NOTES IN THE PR WORKFLOW BEFORE MERGING!!!
What and why?
Continuing the work for primary record types (models > records etc.). This PR covers more updates in the ValidMind Library, Get Started, and ValidMind Academy (training) sections of the documentation. Pulls in the updated notebooks from validmind/validmind-library#509.
Important
THIS PR IS NOT EXHAUSTIVE DUE TO THE LARGE SCOPE OF WORK. Refer to "What needs special review?" for follow-on updates.
How to test
Click on the live previews and review the content:
Get started
ValidMind Library
Quickstart
.envfiles.envfilesHow To
Training
Program
Developer Fundamentals
Validator Fundamentals
What Is ValidMind
What needs special review?
Still lots of updates that need to be made to the docs as this new functionality is pretty all-encompassing.
What's not covered and will be in future Stories (not using the sc link so the GitHub integration doesn't think these Stories are under review due to this PR being linked):
Release notes
n/a
Dependencies, breaking changes, and deployment notes
Checklist