Merge branch 'main' into color-scheme-component

Author: Artur-

.github/workflows/formatter.yml

@@ -45,7 +45,7 @@ jobs:
         id: formatter
         run: |
           echo "Running formatter..."
-          mvn -B -q spotless:apply -P benchmark 2>&1 | grep -v null || true
+          mvn -ntp -B -q spotless:apply -P benchmark 2>&1 | grep -v null || true
 
           # Check for modified files
           files=$(git status --porcelain | awk '{print $2}')

.github/workflows/sonar-pr.yml

@@ -50,7 +50,7 @@ jobs:
       - name: Run Sonar analysis
         run: |
           mvn clean install sonar:sonar \
-            -B -e -V \
+            -ntp -B -e -V \
             -DskipTests \
             -Dsonar.projectKey=vaadin_flow \
             -Dsonar.organization=vaadin \

flow-tests/vaadin-spring-tests/test-spring-common/pom.xml

@@ -156,7 +156,7 @@
     <dependency>
       <groupId>org.springdoc</groupId>
       <artifactId>springdoc-openapi-starter-webmvc-ui</artifactId>
-      <version>2.8.14</version>
+      <version>3.0.0</version>
     </dependency>
 
   </dependencies>

flow-tests/vaadin-spring-tests/test-spring-security-flow/src/main/java/com/vaadin/flow/spring/flowsecurity/views/AdminView.java

@@ -55,16 +55,17 @@ public AdminView(SecurityUtils securityUtils) {
         accessRolePrefixedAdminPageFromThread.setId(ROLE_PREFIX_TEST_BUTTON_ID);
         accessRolePrefixedAdminPageFromThread.addClickListener(event -> {
             UI ui = event.getSource().getUI().get();
-            Runnable doNavigation = () -> {
+            Runnable doNavigation = new DelegatingSecurityContextRunnable(
+                    () -> ui.navigate(RolePrefixedAdminView.class),
+                    SecurityContextHolder.getContext());
+            Runnable delayedNavigation = () -> {
                 try {
                     TimeUnit.MILLISECONDS.sleep(100);
-                    ui.access(() -> ui.navigate(RolePrefixedAdminView.class));
+                    ui.access(doNavigation::run);
                 } catch (InterruptedException e) {
                 }
             };
-            Runnable wrappedRunnable = new DelegatingSecurityContextRunnable(
-                    doNavigation, SecurityContextHolder.getContext());
-            new Thread(wrappedRunnable).start();
+            new Thread(delayedNavigation).start();
         });
         add(accessRolePrefixedAdminPageFromThread);
     }

flow-tests/vaadin-spring-tests/test-spring-security-flow/src/main/java/com/vaadin/flow/spring/flowsecurity/views/PublicView.java

@@ -54,19 +54,17 @@ public PublicView() {
         Button backgroundNavigation = new Button(
                 "Navigate to admin view in 1 second", e -> {
                     UI ui = e.getSource().getUI().get();
+                    Runnable doNavigation = new DelegatingSecurityContextRunnable(
+                            () -> ui.navigate(AdminView.class),
+                            SecurityContextHolder.getContext());
                     Runnable navigateToAdmin = () -> {
                         try {
                             Thread.sleep(1000);
                         } catch (InterruptedException e1) {
                         }
-                        ui.access(() -> {
-                            ui.navigate(AdminView.class);
-                        });
+                        ui.access(doNavigation::run);
                     };
-                    Runnable wrappedRunnable = new DelegatingSecurityContextRunnable(
-                            navigateToAdmin,
-                            SecurityContextHolder.getContext());
-                    new Thread(wrappedRunnable).start();
+                    new Thread(navigateToAdmin).start();
                 });
         backgroundNavigation.setId(BACKGROUND_NAVIGATION_ID);
         add(backgroundNavigation);

pom.xml

@@ -542,6 +542,11 @@
             <propertiesEncoding>UTF-8</propertiesEncoding>
           </configuration>
         </plugin>
+        <plugin>
+          <groupId>org.sonarsource.scanner.maven</groupId>
+          <artifactId>sonar-maven-plugin</artifactId>
+          <version>5.3.0.6276</version>
+        </plugin>
       </plugins>
     </pluginManagement>