[v8] Prepare for migrating v8::MicrotaskQueue to cppgc (#258)

Author: isheludko

src/node_contextify.cc

@@ -125,7 +125,11 @@ ContextifyContext* ContextifyContext::New(Environment* env,
 
   MicrotaskQueue* queue =
       options->own_microtask_queue
+#ifdef V8_CPPGC_MICROTASK_QUEUE
+          ? options->own_microtask_queue
+#else
           ? options->own_microtask_queue.get()
+#endif
           : env->isolate()->GetCurrentContext()->GetMicrotaskQueue();
 
   Local<Context> v8_context;
@@ -146,9 +150,14 @@ ContextifyContext::ContextifyContext(Environment* env,
                                      Local<Object> wrapper,
                                      Local<Context> v8_context,
                                      ContextOptions* options)
+#ifdef V8_CPPGC_MICROTASK_QUEUE
+    : microtask_queue_(options->own_microtask_queue)
+#else
     : microtask_queue_(options->own_microtask_queue
                            ? options->own_microtask_queue.release()
-                           : nullptr) {
+                           : nullptr)
+#endif
+{
   CppgcMixin::Wrap(this, env, wrapper);
 
   context_.Reset(env->isolate(), v8_context);

src/node_contextify.h

@@ -18,7 +18,11 @@ struct ContextOptions {
   v8::Local<v8::String> origin;
   v8::Local<v8::Boolean> allow_code_gen_strings;
   v8::Local<v8::Boolean> allow_code_gen_wasm;
+#ifdef V8_CPPGC_MICROTASK_QUEUE
+  v8::MicrotaskQueue* own_microtask_queue = nullptr;
+#else
   std::unique_ptr<v8::MicrotaskQueue> own_microtask_queue;
+#endif
   v8::Local<v8::Symbol> host_defined_options_id;
   bool vanilla = false;
 };
@@ -122,7 +126,11 @@ class ContextifyContext final : CPPGC_MIXIN(ContextifyContext) {
   }
 
   inline v8::MicrotaskQueue* microtask_queue() const {
+#ifdef V8_CPPGC_MICROTASK_QUEUE
+    return microtask_queue_;
+#else
     return microtask_queue_.get();
+#endif
   }
 
   template <typename T>
@@ -186,7 +194,11 @@ class ContextifyContext final : CPPGC_MIXIN(ContextifyContext) {
       const v8::PropertyCallbackInfo<v8::Array>& args);
 
   v8::TracedReference<v8::Context> context_;
+#ifdef V8_CPPGC_MICROTASK_QUEUE
+  cppgc::Persistent<v8::MicrotaskQueue> microtask_queue_;
+#else
   std::unique_ptr<v8::MicrotaskQueue> microtask_queue_;
+#endif
 };
 
 class ContextifyScript final : CPPGC_MIXIN(ContextifyScript) {

test/cctest/test_environment.cc

@@ -750,15 +750,26 @@ TEST_F(EnvironmentTest, NestedMicrotaskQueue) {
   const v8::HandleScope handle_scope(isolate_);
   const Argv argv;
 
-  std::unique_ptr<v8::MicrotaskQueue> queue = v8::MicrotaskQueue::New(
-      isolate_, v8::MicrotasksPolicy::kExplicit);
+#ifdef V8_CPPGC_MICROTASK_QUEUE
+  v8::MicrotaskQueue*
+#else
+  std::unique_ptr<v8::MicrotaskQueue>
+#endif
+      queue =
+          v8::MicrotaskQueue::New(isolate_, v8::MicrotasksPolicy::kExplicit);
+
   v8::Local<v8::Context> context =
       v8::Context::New(isolate_,
                        nullptr,
                        {},
                        {},
                        v8::DeserializeInternalFieldsCallback(),
-                       queue.get());
+#ifdef V8_CPPGC_MICROTASK_QUEUE
+                       queue
+#else
+                       queue.get()
+#endif
+      );
   node::InitializeContext(context);
   v8::Context::Scope context_scope(context);