including release in dataset (#534)

* including release in dataset

* dataset id tests

---------

Co-authored-by: Nathan Perkins <[email protected]>

Author: Nathanjp91

darwin/client.py

@@ -188,6 +188,8 @@ def get_remote_dataset(self, dataset_identifier: Union[str, DatasetIdentifier])
                 )
         if not matching_datasets:
             raise NotFound(str(parsed_dataset_identifier))
+        if parsed_dataset_identifier.version:
+            matching_datasets[0].release = parsed_dataset_identifier.version
         return matching_datasets[0]
 
     def create_dataset(self, name: str, team_slug: Optional[str] = None) -> RemoteDataset:
@@ -227,7 +229,6 @@ def create_dataset(self, name: str, team_slug: Optional[str] = None) -> RemoteDa
                 progress=0,
                 client=self,
             )
-        end
 
     def archive_remote_dataset(self, dataset_id: int, team_slug: str) -> None:
         """

darwin/dataset/remote_dataset.py

@@ -107,6 +107,7 @@ def __init__(
         item_count: int = 0,
         progress: float = 0,
         version: int = 1,
+        release: Optional[str] = None,
     ):
         self.team = team
         self.name = name
@@ -118,6 +119,7 @@ def __init__(
         self.annotation_types: Optional[List[Dict[str, Any]]] = None
         self.console: Console = Console()
         self.version = version
+        self.release = release
 
     @abstractmethod
     def push(
@@ -652,7 +654,10 @@ def get_release(self, name: str = "latest") -> "Release":
         if not releases:
             raise NotFound(str(self.identifier))
 
-        if name == "latest":
+        # overwrite default name with stored dataset.release if supplied
+        if self.release and name == "latest":
+            name = self.release
+        elif name == "latest":
             return next((release for release in releases if release.latest))
 
         for release in releases:

darwin/dataset/remote_dataset_v2.py

@@ -12,6 +12,8 @@
 
 from requests.models import Response
 
+from requests.models import Response
+
 from darwin.dataset import RemoteDataset
 from darwin.dataset.release import Release
 from darwin.dataset.upload_manager import (

tests/darwin/dataset/remote_dataset_test.py

@@ -306,6 +306,24 @@ def files_content() -> Dict[str, Any]:
     }
 
 
+def test_dataset_creation_from_id():
+    def it_should_set_id_correctly_from_id(darwin_client: Client):
+        dataset_id = "team_slug/dataset_name:test_release"
+        dataset = darwin_client.get_remote_dataset(dataset_id)
+
+        assert dataset.slug == "team_slug"
+        assert dataset.name == "dataset_name"
+        assert dataset.release == "test_release"
+
+    def it_should_work_without_a_release(darwin_client: Client):
+        dataset_id = "team_slug/dataset_name"
+        dataset = darwin_client.get_remote_dataset(dataset_id)
+
+        assert dataset.slug == "team_slug"
+        assert dataset.name == "dataset_name"
+        assert dataset.release == None
+
+
 @pytest.mark.usefixtures("file_read_write_test", "create_annotation_file")
 def describe_split_video_annotations():
     def it_works_on_videos(