UD nomulus pre alpha2 #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrtp
reviewed
May 6, 2025
gradle.properties
Outdated
| nomulus_version= | ||
| dot_path=/usr/bin/dot | ||
| pipeline= | ||
| org.gradle.java.home=/opt/homebrew/opt/openjdk@21 |
Collaborator
There was a problem hiding this comment.
I don't think this line is required, as Gradle picks up the correct JDK automatically for me without it. WOuld be better to keep out env-specific paths (this path doesn't work on my laptop)
gradle.properties
Outdated
Comment on lines
32
to
35
| dbServer=127.0.0.1:15432 | ||
| dbName=nomulus | ||
| dbUser=nomulus | ||
| dbPassword=changeMe123 |
Collaborator
There was a problem hiding this comment.
Can we replace these db* variables with the empty ones above so they aren't repeated?
Collaborator
|
@UDtorrey I converted this to a draft so that we don't accidentally merge it. Leaving as a branch/PR should be sufficient for us to use in local builds for now until we have other options 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
config and instructions as needed to deploy
alphaenvironment into a GCP projectnomulus pre-alpha2.1st attempt at clean doc for depeloyment
be aware of the
testFilter=whateverin thegradle.properties. This is a work around if tests are failing on the build/deploy machine.Copliot generate summary
This pull request introduces several updates to support the
nomulus-pre-alpha2environment, including configuration changes, deployment instructions, and database adjustments. It also includes updates to premium list files, TLD configurations, and scaling parameters for various services.Configuration and Deployment Updates:
nomulus-pre-alpha2environment inUD_README.md, including build and deployment commands, as well as instructions for running the Nomulus CLI tool locally.nomulus-config-alpha.yamlwith environment-specific settings fornomulus-pre-alpha2, including GCP project details, OAuth configurations, and Cloud SQL connection settings.gradle.propertiesto include database connection details and Java home configuration for the new environment.projects.gradleto point thealphaenvironment tonomulus-pre-alpha2.Database and Cloud SQL Adjustments:
jdbcUrlindefault-config.yamlto include the port number for the local PostgreSQL instance.NomulusPostgreSql.javaby removing architecture-specific prefixes.Premium Lists and TLD Configuration:
demo1.txtanddemo2.txt) for managing premium domains with the Nomulus tool. [1] [2]demo1.yamlanddemo2.yaml) to define settings for thedemo1anddemo2TLDs. [1] [2]Scaling and Resource Optimization:
max-instancesfor various services inappengine-web.xmlfiles to optimize resource usage in thealphaenvironment: