[Feature] The import messages "Unsloth: Will patch your computer" and "Unsloth Zoo will now patch everything" should be more precise
#2532
Replies: 8 comments
-
|
There are a lot of patches, and they're model dependent so by default we don't print the logs of this. You can try |
Beta Was this translation helpful? Give feedback.
-
|
"will patch your computer" and "will now patch everything" is really scary :) are any patches happening at the import time? when the model name is not available yet |
Beta Was this translation helpful? Give feedback.
-
|
Yes, many of the patches are happening at import time. I'd recommend running in a virtualenv. |
Beta Was this translation helpful? Give feedback.
-
|
IMO all these patches should be always verbose-logged by default and explained what exactly is patched and how... spooky action at a distance is scary, especially if it's persistent |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for the feedback. I dropped a note to the team as well. In general we want to keep the logging on the cleaner side by default, and going forward will make sure to consider what additional logging to add in future releases. |
Beta Was this translation helpful? Give feedback.
-
|
I just want to say that 'patch your computer' indeed sounds uncomfortable for people who know what're in their computers. Maybe a better wording is 'patch Transformer and other libraries'. |
Beta Was this translation helpful? Give feedback.
-
|
patch Maybe what could be done is adding an |
Beta Was this translation helpful? Give feedback.
-
|
There is no current plan for this, however i'll move this to discussions to warrant it potential future consideration |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
and list exactly what patches they are applying and where
Hopefully, these patches can be accepted by upstream PyTorch and HF some day and not be needed :) or at least, be registered with them in a more graceful way than patching
Beta Was this translation helpful? Give feedback.
All reactions