From d7bb5d061e101d8fa0d8c21cca8cb27acd383893 Mon Sep 17 00:00:00 2001
From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Date: Sun, 5 Apr 2026 14:12:02 -0400
Subject: [PATCH] Move injected deps sync to _syncPnpm (runs after builds, not
 before)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The previous fix (#703) put pnpm install --frozen-lockfile in the
sync scripts and made //#sync uncached. But //#sync runs before
ember-primitives:build (it has no dependsOn), so the injected deps
were synced before dist/ existed — same failure.

The correct place is _syncPnpm, which turbo already configures with
dependsOn: ["^build"] and cache: false. This ensures the sync runs
after upstream builds complete (dist/ exists) and before downstream
consumers (docs-app:build:dev).

Changes:
- Add _syncPnpm script to docs-app and test-app: pnpm install --frozen-lockfile
- Restore sync scripts to their original echo stubs
- Restore //#sync to cacheable (it just runs the echo stubs, no need to bust cache)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 docs-app/package.json | 3 ++-
 test-app/package.json | 3 ++-
 turbo.json            | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/docs-app/package.json b/docs-app/package.json
index 0d7ce155a..792f4f020 100644
--- a/docs-app/package.json
+++ b/docs-app/package.json
@@ -24,7 +24,8 @@
     "format": "prettier --write .",
     "start": "pnpm vite",
     "dev": "vite",
-    "sync": "pnpm install --frozen-lockfile",
+    "_syncPnpm": "pnpm install --frozen-lockfile",
+    "sync": "echo 'pnpm is syncing injected deps. (this is configured in .npmrc)'",
     "test:ember": "vite build --mode development && testem ci --port 0"
   },
   "dependencies": {
diff --git a/test-app/package.json b/test-app/package.json
index eb15cc1af..851e4c774 100644
--- a/test-app/package.json
+++ b/test-app/package.json
@@ -22,7 +22,8 @@
     "format": "prettier --write .",
     "start": "pnpm vite",
     "dev": "vite",
-    "sync": "pnpm install --frozen-lockfile",
+    "_syncPnpm": "pnpm install --frozen-lockfile",
+    "sync": "echo 'pnpm is syncing injected deps. (this is configured in .npmrc)'",
     "test:ember": "vite build --mode development && testem ci --port 0"
   },
   "dependencies": {
diff --git a/turbo.json b/turbo.json
index 32812ebf0..9fb7c025e 100644
--- a/turbo.json
+++ b/turbo.json
@@ -79,7 +79,7 @@
       "outputs": ["dist/**", "dist-types/**", "declarations/**", "docs.json"],
       "dependsOn": ["_syncPnpm", "//#sync"]
     },
-    "//#sync": { "cache": false },
+    "//#sync": {},
     "_syncPnpm": {
       "dependsOn": ["^build"],
       "cache": false