Skip to content

Commit e6bd47a

Browse files
committed
ICU-20438 Further updating readme and instructions for commit-checker.
1 parent 47ef617 commit e6bd47a

File tree

2 files changed

+17
-11
lines changed

2 files changed

+17
-11
lines changed

tools/commit-checker/README.md

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,28 +13,34 @@ Author: Shane Carr
1313

1414
Install `pipenv` globally:
1515

16-
$ sudo pip3 install pipenv
16+
$ sudo pip3 install pipenv
1717

1818
Install this project's dependencies locally:
1919

20-
$ pipenv install
20+
$ pipenv install
2121

2222
Optional: save your Jira credentials in a `.env` file in this directory:
2323

24-
JIRA_USERNAME=hello
25-
JIRA_PASSWORD=world
24+
JIRA_USERNAME=hello
25+
JIRA_PASSWORD=world
2626

2727
This is required if you want to process sensitive tickets.
2828

2929
## Usage
3030

3131
Make sure you have updated your repository:
3232

33-
$ git pull upstream master
34-
$ git fetch --tags upstream
33+
$ git checkout master
34+
$ git pull upstream master
35+
$ git fetch --tags upstream
3536

36-
Run the tool and save the result into REPORT.md:
37+
Sanity check: ensure that the "latest" tag is correct (points to the latest release). You may need to force-fetch the tags.
3738

38-
$ pipenv run python3 check.py --jira-query "project=ICU AND fixVersion=63.1" > REPORT.md
39+
$ git show latest
40+
# should show a commit with both "latest" and the previous version number
3941

40-
Open a pull request so others can view the report easilly.
42+
Run the tool and save the result into REPORT.md; set fixVersion to the *upcoming* ICU version:
43+
44+
$ pipenv run python3 check.py --jira-query "project=ICU AND fixVersion=64.1" > REPORT.md
45+
46+
Create a branch and open a pull request so others can view the report easily.

tools/commit-checker/check.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ class CommitWanted(Enum):
5252
)
5353
flag_parser.add_argument(
5454
"--jira-query",
55-
help = "JQL query to match with tickets.",
56-
default = "project=ICU AND fixVersion=63.1"
55+
help = "JQL query load tickets; this should match tickets expected to correspond to the commits being checked. Example: 'project=ICU and fixVersion=63.1'; set fixVersion to the upcoming version.",
56+
required = True
5757
)
5858

5959

0 commit comments

Comments
 (0)