Skip to content

V16 QA updated E2E tests #19710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

V16 QA updated E2E tests #19710

wants to merge 3 commits into from

Conversation

andr317c
Copy link
Contributor

Updated the acceptance test to reduce failing/flakyness on the nightly pipeline

@Copilot Copilot AI review requested due to automatic review settings July 11, 2025 08:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates to multiple E2E tests to reduce flakiness by replacing direct notification checks, introducing explicit wait methods, and refactoring repetitive test helpers.

  • Replaced brittle success/error notification assertions with dedicated waitFor* and does*WorkspaceHaveText methods
  • Refactored media/data type crop tests to use structured crop objects and unified create button calls
  • Marked known flaky test as test.fixme and bumped @umbraco/playwright-testhelpers dependency

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/.../Webhook/WebhookTrigger.spec.ts Swapped notification check for waitForRecycleBinToBeEmptied
tests/.../Users/UserGroups.spec.ts Updated uiPermission array item from 'Browse' to 'Read'
tests/.../Settings/DocumentType/DocumentTypeDesignTab.spec.ts Changed reorder test to test.fixme and added missing arg
tests/.../DataType/MediaPicker.spec.ts Refactored crop data to object, unified create button calls
tests/.../Settings/Dashboard/Telemetry.spec.ts Added explicit timeouts, switched to doesTelemetryDataLevelHaveValue
tests/Umbraco.Tests.AcceptanceTest/package.json Bumped @umbraco/playwright-testhelpers to ^16.0.28
Files not reviewed (1)
  • tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported
Comments suppressed due to low confidence (4)

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/User.spec.ts:116

  • [nitpick] The variable name danishIsoCode implies a full locale (e.g., 'da-DK'), but the value is just 'da'. Either rename the variable to reflect its content (languageCode) or use the full ISO code if required by the API.
  const danishIsoCode = 'da';

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeDesignTab.spec.ts:274

  • The variable groupName is not defined in this scope, which will cause a ReferenceError. Introduce a definition for groupName (e.g., const groupName = 'FirstGroup';) or adjust the arguments accordingly.
  const groupValues = await umbracoUi.documentType.reorderTwoGroups(groupName, secondGroupName);

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/MediaPicker.spec.ts:75

  • Calling clickCreateCropButton before entering values may not open the crop creation panel if the intended method was clickAddCropButton. Verify the correct helper method and remove any duplicate button calls.
  await umbracoUi.dataType.clickCreateCropButton();

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/UserGroups.spec.ts:6

  • The uiPermission entry was changed from 'Browse' to 'Read'. Ensure that the application expects 'Read' and not 'Browse'—mismatched permission labels can lead to unexpected access behavior.
    ['Read',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant