Set up standard logging module #2232
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the advantage of overall less custom code; as well as support for per-module configuration. This would enable a potential solution for ultrabug#1479, since in the future it can allow per-module configuration of log levels. I expect this to mainly help module creators, allowing them to enable logging for only their module, while disabling all other messages. It also is easier to use, since the `logging` module's interface is generally simpler than `self.py3`. Here, I've made the decision to keep the message format as close as possible to the existing log messages.
|
Looks like a simple yet effective start mate, would you want to keep on that? |
|
This is a clean rebase attempt on the master. I have much more on my side, but I have stopped working on it for a while mainly because I'm on KDE so I'm not using py3status now. If and when I get back to this, I will try again. I didn't like a separate file to deal with logs because I think we would forget about that... so I'm trying to put the logger configs inside |
|
@ultrabug It was obvious that I have no motivation to keep working on this. Feel free to just close issue+PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting an attempt to close #2063 with #2064.