[production/RRFS.v1] RRFS restart reproducibility fix

[JiliDong-NOAA]

Description of Changes:

This PR will fix RRFS restart reproducibility issue when cumulus convection is applied, including saSAS and Grell-Freitas

Tests Conducted:

Tests have been performed on RRFS deterministic/control member and REFS ensemble members

Dependencies:

Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example:

• NCAR/ccpp-framework#<pr_number>
• NOAA-EMC/fv3atm#<pr_number>
• ufs-community/ufs-weather-model/#<pr_number>

Documentation:

Does this PR add new capabilities that need to be documented or require modifications to the existing documentation? If so, brief supporting material can be provided here. Contact the CODEOWNERS if your PR requires extensive updates to the documentation. See https://github.com/NCAR/ccpp-doc for Technical Documentation or https://dtcenter.org/community-code/common-community-physics-package-ccpp/documentation for the latest Scientific Documentation.

Issue (optional):

This PR will do the following:

1. not force qadv to zero in the first timestep of saSAS when restarting
2. only set forcet/forceq to zero in the first timestep when calling Grell-Freitas convection

The PR fixes issue #318

Contributors (optional):

If others have contributed to this work aside from the PR author, list them here

[grantfirl]

@JiliDong-NOAA Is this at all related to ufs-community/ufs-weather-model#2759? (I'm guessing no)

[JiliDong-NOAA]

@JiliDong-NOAA Is this at all related to ufs-community/ufs-weather-model#2759? (I'm guessing no)

@grantfirl I don't think so. Issue 2759 appears to be related to Noah MP while this PR is for the upcoming RRFSV1 operational implementation, which doesn't use Noah MP LSM.

[grantfirl]

@JiliDong-NOAA I see that ufs-community/ufs-weather-model#2925 (comment) showed some compilation failures. It looks like the C3 convection scheme also calls progsigma_calc, so please fix the calls to that routine in the C3 scheme as well to pass compilation.

[JiliDong-NOAA]

@JiliDong-NOAA I see that ufs-community/ufs-weather-model#2925 (comment) showed some compilation failures. It looks like the C3 convection scheme also calls progsigma_calc, so please fix the calls to that routine in the C3 scheme as well to pass compilation.

fixed

[grantfirl]

@JiliDong-NOAA Do you know if these same changes should go into the ufs/dev branch?

[JiliDong-NOAA]

@JiliDong-NOAA Do you know if these same changes should go into the ufs/dev branch?

Two convection schemes are involved in these changes:

1. saSAS. In the current ufs/dev, the initial sigma b minimum value for deep convection is always set to sigmind=0.01 during either warm start (with cycled DA) or restart. The change is to allow the value to vary based on the namelist parameter sigmab_coldstart:

• 0.0 when warm starting with sigmab_coldstart=T
• 0.01 when restarting with sigmab_coldstart=F.

For applications other than RRFS, this change will have no impact unless sigmab_coldstart is explicitly included as T in namelist. It is also safe to sync this change back into ufs/dev.

2. Grell-Freitas. The change fixes a potential bug that occurs when gf_coldstart is set to T and should be merged back into ufs/dev.