Skip to content

Log for span with exception in traced_function decorator doesn't match the opentracing spec #99

@condorcet

Description

@condorcet

Hello!

As I understand this logs are obsolete:
https://github.com/uber-common/opentracing-python-instrumentation/blob/master/opentracing_instrumentation/local_span.py#L166
https://github.com/uber-common/opentracing-python-instrumentation/blob/master/opentracing_instrumentation/local_span.py#L179

... and doesn't match the specification https://github.com/opentracing/specification/blob/master/semantic_conventions.md
There is no payload field and event="error' fits for exceptions better rather than "exception".

Am I right? Should we use standards fields in the decorator?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions