From c09e87285750bc4c99ad21a501145c4596b901b2 Mon Sep 17 00:00:00 2001
From: Hugo van Rijswijk <git@hugovr.nl>
Date: Tue, 25 Aug 2026 13:12:24 +0200
Subject: [PATCH] Remove .fail from now-passing conformance cases

Was fixed in #908
---
 .../src/test/scala/conformance/TypeSystemSuite.scala |  6 +-----
 .../scala/conformance/ValidationVariablesSuite.scala | 12 ++++++------
 2 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/modules/core/src/test/scala/conformance/TypeSystemSuite.scala b/modules/core/src/test/scala/conformance/TypeSystemSuite.scala
index c500b696..931ad701 100644
--- a/modules/core/src/test/scala/conformance/TypeSystemSuite.scala
+++ b/modules/core/src/test/scala/conformance/TypeSystemSuite.scala
@@ -660,12 +660,8 @@ final class TypeSystemSuite extends ConformanceSuite {
     }
   """)
 
-  // The specification marks the next document as an example, and the note below it states that
-  // the Validation section defines the document as invalid. Rule 5.8.5 applies, and grackle has
-  // no check for that rule. The test case supplies a value for `$var`, because the rule holds
-  // for every value. Without a value, the test case would pass because the value is absent.
   invalidQuery(
-    "a nullable variable cannot be supplied to a non-null argument".fail,
+    "a nullable variable cannot be supplied to a non-null argument",
     NonNullArgSchema,
     json"""{"var": "x"}""")("""
     query withNullableVariable($var: String) {
diff --git a/modules/core/src/test/scala/conformance/ValidationVariablesSuite.scala b/modules/core/src/test/scala/conformance/ValidationVariablesSuite.scala
index 8bcf989f..83d0682d 100644
--- a/modules/core/src/test/scala/conformance/ValidationVariablesSuite.scala
+++ b/modules/core/src/test/scala/conformance/ValidationVariablesSuite.scala
@@ -109,7 +109,7 @@ final class ValidationVariablesSuite extends ValidationSuite {
   // 5.8.2. The operation uses the variable, which leaves rule 5.8.2 as the only reason to reject
   // the document. Grackle has no check for that rule and accepts the document. Rule 5.8.5 also
   // forbids this usage, and grackle has no check for that rule either.
-  invalidQuery("a variable of object type which the operation uses".fail)("""
+  invalidQuery("a variable of object type which the operation uses")("""
     query takesCat($cat: Cat) {
       findDog(searchBy: $cat) {
         name
@@ -276,7 +276,7 @@ final class ValidationVariablesSuite extends ValidationSuite {
   // fits the argument therefore needs such a value here. Without one, the test case would pass
   // because the value is absent, not because the rule holds.
 
-  invalidQuery("an Int variable cannot go into a Boolean argument".fail)("""
+  invalidQuery("an Int variable cannot go into a Boolean argument")("""
     query intCannotGoIntoBoolean($intArg: Int) {
       arguments {
         booleanArgField(booleanArg: $intArg)
@@ -284,7 +284,7 @@ final class ValidationVariablesSuite extends ValidationSuite {
     }
   """)
 
-  invalidQuery("a list variable cannot go into a non-list argument".fail)("""
+  invalidQuery("a list variable cannot go into a non-list argument")("""
     query booleanListCannotGoIntoBoolean($booleanListArg: [Boolean]) {
       arguments {
         booleanArgField(booleanArg: $booleanListArg)
@@ -293,7 +293,7 @@ final class ValidationVariablesSuite extends ValidationSuite {
   """)
 
   invalidQuery(
-    "a nullable variable cannot go into a non-null argument".fail,
+    "a nullable variable cannot go into a non-null argument",
     vars = json"""{"booleanArg": true}""")("""
     query booleanArgQuery($booleanArg: Boolean) {
       arguments {
@@ -313,7 +313,7 @@ final class ValidationVariablesSuite extends ValidationSuite {
   """)
 
   invalidQuery(
-    "a nullable list variable cannot go into a non-null list argument".fail,
+    "a nullable list variable cannot go into a non-null list argument",
     vars = json"""{"booleanList": [true]}""")("""
     query listToNonNullList($booleanList: [Boolean]) {
       arguments {
@@ -348,7 +348,7 @@ final class ValidationVariablesSuite extends ValidationSuite {
     }
   """)
 
-  validQuery("a nullable variable can go into a non-null argument which has a default".fail)("""
+  validQuery("a nullable variable can go into a non-null argument which has a default")("""
     query booleanArgQueryWithDefault($booleanArg: Boolean) {
       arguments {
         optionalNonNullBooleanArgField(optionalBooleanArg: $booleanArg)