You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We already opened a previous RFC about adopting Lit in #699 and that has been a successful endeavor. As we look toward a new major version, in order to refactor other existing components to use Lit we should consider migrating the whole library to use Lit so that the patterns are standard across all components.
This has the potential to introduce minor breaking API changes, but we may be able to handle this with codemods.
Why refactor every component?
We want to make the library more approachable, and move off of our vanilla JS based implementation. This will also reduce the bundle size of Forge significantly as well, and improve performance across the board.
We also do not want to be in a situation where maintainers need to spend time switching between the patterns in the library frequently just because the architecture is different across components.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
We already opened a previous RFC about adopting Lit in #699 and that has been a successful endeavor. As we look toward a new major version, in order to refactor other existing components to use Lit we should consider migrating the whole library to use Lit so that the patterns are standard across all components.
This has the potential to introduce minor breaking API changes, but we may be able to handle this with codemods.
Why refactor every component?
We want to make the library more approachable, and move off of our vanilla JS based implementation. This will also reduce the bundle size of Forge significantly as well, and improve performance across the board.
We also do not want to be in a situation where maintainers need to spend time switching between the patterns in the library frequently just because the architecture is different across components.
Beta Was this translation helpful? Give feedback.
All reactions