You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have typically always exported all modules from Forge, which can have the side-effect of exposing APIs that were only intended for internal use. We've seen this specifically with our "constants" files that most components have. This is where we place static constant values as well as types and interfaces.
Rather than exposing these constants, we should be more explicit about which modules they are placed in and whether they are exported or not. This will allow for us to make internal changes changes more easily when we need to adjust these constants, without worrying if consumers are relying on them.
As we migrate to Lit and simplify our component architecture, these constants files will likely become less and less used (if at all).
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
We have typically always exported all modules from Forge, which can have the side-effect of exposing APIs that were only intended for internal use. We've seen this specifically with our "constants" files that most components have. This is where we place static constant values as well as types and interfaces.
Rather than exposing these constants, we should be more explicit about which modules they are placed in and whether they are exported or not. This will allow for us to make internal changes changes more easily when we need to adjust these constants, without worrying if consumers are relying on them.
As we migrate to Lit and simplify our component architecture, these constants files will likely become less and less used (if at all).
Beta Was this translation helpful? Give feedback.
All reactions