retries for network errors (e.g. ECONNRESET)

[mfulton26]

sometimes Twilio calls fail for intermittent network/server errors (e.g. ECONNRESET); can the Auto-Retry with Exponential Backoff be updated or a similar option added to also retry under these conditions?

twilio-node/src/base/RequestClient.ts

Lines 37 to 66 in 55db7c2

	function getExponentialBackoffResponseHandler(
	axios: AxiosInstance,
	opts: ExponentialBackoffResponseHandlerOptions
	) {
	const maxIntervalMillis = opts.maxIntervalMillis;
	const maxRetries = opts.maxRetries;
	return function (res: AxiosResponse<any, any>) {
	const config: BackoffAxiosRequestConfig = res.config;
	if (res.status !== 429) {
	return res;
	}
	const retryCount = (config.retryCount || 0) + 1;
	if (retryCount <= maxRetries) {
	config.retryCount = retryCount;
	const baseDelay = Math.min(
	maxIntervalMillis,
	DEFAULT_INITIAL_RETRY_INTERVAL_MILLIS * Math.pow(2, retryCount)
	);
	const delay = Math.floor(baseDelay * Math.random()); // Full jitter backoff
	return new Promise((resolve: (value: Promise<AxiosResponse>) => void) => {
	setTimeout(() => resolve(axios(config)), delay);
	});
	}
	return res;
	};
	}

[adar-h-healthy]

@tiwarishubham635 Can you please relate to this one? 🙏 We started to get multiple ECONNABORTED errors and this addition can help a lot.

[tiwarishubham635]

We have recently made these changes. I think this will help in your case. This will be available in the coming release

[adar-h-healthy]

@tiwarishubham635 I might be missing something, but I can't see how this change can help here... It gives the option to change the timeout value, but it doesn't allow to override the retry configuration.

[adar-h-healthy]

@tiwarishubham635 Would it be ok if we'll open a PR with the change recommended in this issue?

[tiwarishubham635]

Sure, I'll be happy to review it

[adar-h-healthy]

@tiwarishubham635 I'm having second thoughts about this and you might be able to assist. In some cases when we get the ECONNABORTED error (due to timeout), the request did manage to get to Twilio and the SMS is sent. If we will introduce this retry mechanism, it means that the same request MIGHT be sent twice to Twilio API. I assume that your side supports idempotency, but I wanted to validate this before starting.

[tiwarishubham635]

Yes, we do support Idempotency

[mfulton26]

@manisha1997 has a change been made to support retries for network errors (e.g. ECONNRESET)? last I checked twilio-node only retries 429 errors.

[manisha1997]

Apologies!