-
Notifications
You must be signed in to change notification settings - Fork 107
Open
Description
Description
This issue addresses code style and formatting inconsistencies across several components. The changes focus on improving code readability and maintaining consistent patterns.
Changes Made
1. Password Strength Component (components/ui/password-strength.tsx
)
- Improved function parameter formatting for better readability
- Reordered CSS classes to follow consistent pattern
- export function PasswordStrength({ password, className }: PasswordStrengthProps) {
+ export function PasswordStrength({
+ password,
+ className,
+ }: PasswordStrengthProps) {
- <div className="h-1 w-full bg-gray-200 rounded-full overflow-hidden">
+ <div className="h-1 w-full overflow-hidden rounded-full bg-gray-200">
2. Signup Form (components/auth/signup.tsx
)
- Improved component props formatting
- <PasswordStrength password={field.value} className="mt-2" />
+ <PasswordStrength
+ password={field.value}
+ className="mt-2"
+ />
3. Form Skeleton (components/ui/form-skeleton.tsx
)
- Reordered CSS classes to follow consistent pattern
- <div className="h-4 w-24 bg-gray-200 rounded animate-pulse" />
- <div className="h-10 w-full bg-gray-200 rounded animate-pulse" />
- <div className="h-10 w-full bg-gray-200 rounded animate-pulse mt-6" />
+ <div className="h-4 w-24 animate-pulse rounded bg-gray-200" />
+ <div className="h-10 w-full animate-pulse rounded bg-gray-200" />
+ <div className="mt-6 h-10 w-full animate-pulse rounded bg-gray-200" />
CSS Class Ordering Convention
The changes follow a consistent CSS class ordering pattern:
- Layout properties (e.g.,
mt-6
,w-full
) - Animation properties (e.g.,
animate-pulse
) - Visual properties (e.g.,
rounded
,bg-gray-200
)
Impact
- Improved code readability
- Consistent code style across components
- Better maintainability
- Follows established CSS class ordering conventions
Type of Change
- Code style update (formatting, renaming)
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- Documentation update
Checklist
- My code follows the style guidelines of this project
- I have performed a self-review of my own code
- I have commented my code, particularly in hard-to-understand areas
- My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes
Additional Context
These changes were made to maintain consistency across the codebase and improve readability. No functional changes were made to the components.
Metadata
Metadata
Assignees
Labels
No labels