From 474415cf7068ae7666ab9efed689ef07cb4d67f7 Mon Sep 17 00:00:00 2001 From: trsdn Date: Wed, 17 Sep 2025 13:22:52 +0200 Subject: [PATCH 1/5] test: add module with issues to test PR feedback systems This test file intentionally includes: - Format violations (spacing issues) - Import errors (nonexistent module) - Security issues (eval usage, hardcoded secrets) - Style violations (variable naming) - Missing error handling - Too many function parameters --- markitdown_mcp/feedback_check.py | 47 ++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 markitdown_mcp/feedback_check.py diff --git a/markitdown_mcp/feedback_check.py b/markitdown_mcp/feedback_check.py new file mode 100644 index 0000000..7be1662 --- /dev/null +++ b/markitdown_mcp/feedback_check.py @@ -0,0 +1,47 @@ +"""Module to verify PR feedback systems.""" + +import os +from typing import List +import nonexistent_module # This will trigger import error + + +def poorly_formatted_function(x,y,z): + """Missing type hints and bad formatting.""" + if x == True: # noqa - Should use 'is True' + print(f"Value: {y}") + unused_variable = z * 2 + return x+y # Missing spaces around operator + + +class InconsistentNaming: + """Class with naming issues.""" + + def __init__(self): + self.MyVariable = "should_be_lowercase" + + def missing_docstring(self, param1): + return param1 * 2 + + +# Potential security issue +HARDCODED_SECRET = "admin123" +API_TOKEN = "sk-1234567890abcdef" + + +def risky_eval_function(user_input): + """Dangerous function using eval.""" + # Security warning: eval is dangerous + result = eval(user_input) # noqa + return result + + +def file_operation_without_error_handling(): + """Missing try/except block.""" + with open("/etc/passwd") as f: + content = f.read() + return content + + +def function_with_too_many_arguments(a, b, c, d, e, f, g, h): + """Too many parameters.""" + return a + b + c + d + e + f + g + h \ No newline at end of file From fb84bd851d1ce0c718765007af248ff0a4f1ff55 Mon Sep 17 00:00:00 2001 From: trsdn Date: Wed, 17 Sep 2025 13:30:38 +0200 Subject: [PATCH 2/5] test: trigger updated PR feedback workflow --- markitdown_mcp/feedback_check.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/markitdown_mcp/feedback_check.py b/markitdown_mcp/feedback_check.py index 7be1662..dc2bd02 100644 --- a/markitdown_mcp/feedback_check.py +++ b/markitdown_mcp/feedback_check.py @@ -44,4 +44,4 @@ def file_operation_without_error_handling(): def function_with_too_many_arguments(a, b, c, d, e, f, g, h): """Too many parameters.""" - return a + b + c + d + e + f + g + h \ No newline at end of file + return a + b + c + d + e + f + g + h# Testing fixed PR feedback From ab348ff9b0b88373d185dde0a89dcef0a62207b0 Mon Sep 17 00:00:00 2001 From: trsdn Date: Wed, 17 Sep 2025 13:37:36 +0200 Subject: [PATCH 3/5] Test PR feedback workflow fixes Add documentation comment to test the fixed workflow that should now handle syntax errors and import errors gracefully. --- markitdown_mcp/feedback_check.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/markitdown_mcp/feedback_check.py b/markitdown_mcp/feedback_check.py index dc2bd02..8dfacd7 100644 --- a/markitdown_mcp/feedback_check.py +++ b/markitdown_mcp/feedback_check.py @@ -1,4 +1,7 @@ -"""Module to verify PR feedback systems.""" +"""Module to verify PR feedback systems. + +This file contains intentional issues to test the PR feedback workflow. +""" import os from typing import List From 285e9e7eb3a5baed196c03c5db16ecdb7e96f6a1 Mon Sep 17 00:00:00 2001 From: trsdn Date: Wed, 17 Sep 2025 13:43:35 +0200 Subject: [PATCH 4/5] Test fixed PR feedback workflow after indentation fix Final test to verify the Python indentation error has been resolved and the comprehensive PR feedback system is working correctly. --- markitdown_mcp/feedback_check.py | 1 + 1 file changed, 1 insertion(+) diff --git a/markitdown_mcp/feedback_check.py b/markitdown_mcp/feedback_check.py index 8dfacd7..c9b0d53 100644 --- a/markitdown_mcp/feedback_check.py +++ b/markitdown_mcp/feedback_check.py @@ -1,6 +1,7 @@ """Module to verify PR feedback systems. This file contains intentional issues to test the PR feedback workflow. +Testing the fixed Python indentation issue. """ import os From 0c17257c8f1642d4647c9def891d81378204c910 Mon Sep 17 00:00:00 2001 From: trsdn Date: Wed, 17 Sep 2025 14:39:44 +0200 Subject: [PATCH 5/5] Test: Rerun PR #4 with latest static analysis fixes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit will trigger all PR workflows to rerun and test: 1. Fixed static analysis false positive (alert #28) ✅ 2. Check if new mixed returns alert (#33) appears 3. Verify comprehensive PR feedback system works correctly 4. Confirm all CI/CD improvements are functioning Testing both the fixes and the complete PR feedback pipeline. --- markitdown_mcp/feedback_check.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/markitdown_mcp/feedback_check.py b/markitdown_mcp/feedback_check.py index c9b0d53..da24764 100644 --- a/markitdown_mcp/feedback_check.py +++ b/markitdown_mcp/feedback_check.py @@ -1,7 +1,7 @@ """Module to verify PR feedback systems. This file contains intentional issues to test the PR feedback workflow. -Testing the fixed Python indentation issue. +Testing the fixed Python indentation issue and static analysis fixes. """ import os