Tpetra: Fence at the end of endTransfer #14677
Draft
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CDash for AT1 results [Only accessible from Sandia networks] |
cgcgcg
force-pushed
the
tpetraTranferFences
branch
2 times, most recently
from
6f4ba34 to
a335ad1
Compare
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: cgcgcg |
jhux2
requested changes
Nov 10, 2025
| } // if (CM != ZERO) | ||
|
|
||
| // Guarantee that copyAndPermute and unpackAndCombine are done. | ||
| execution_space().fence("Tpetra::DistObject::endTransfer"); |
Member
There was a problem hiding this comment.
Does the comment above on line 935-937 apply here?
Contributor
Author
There was a problem hiding this comment.
I don't think so. We don't really know where the data will get accessed next. So we cannot rely on fences in sync. (And ideally we run everything on device anyway, so there is no sync.)
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
Contributor
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Signed-off-by: Christian Glusa <[email protected]>
cgcgcg
force-pushed
the
tpetraTranferFences
branch
from
a335ad1 to
b7b3844
Compare
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: cgcgcg |
Contributor
|
NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester... |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: cgcgcg |
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
cgcgcg
added
the
AT: WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/tpetra
Motivation
This PR moves the fence from
MultiVector::copyAndPermuteto the end ofDistObject::endTransfer.Questions:
CM == ADD_ASSIGNinMultiVector::copyAndPermute. I think that we need the same fence, regardless of the combine mode?copyAndPermutefor other objects derived fromDistObject, but didn't find them.