Tpetra: Implementing the SolverMapTransform. Tests also included. #14279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CDash for AT1 results [Only accessible from Sandia networks] |
eeprude
requested review from
ccober6 and
hkthorn
and removed request for
a team
eeprude
changed the title
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: eeprude |
Signed-off-by: Ernesto Prudencio <[email protected]>
eeprude
force-pushed
the
417_solverMapReady
branch
from
962eba7 to
cf68ff2
Compare
Contributor
|
Status Flag 'Pull Request AutoTester' - Error: Jenkins Jobs - A user has pushed a change to the PR before testing completed. NEW EVENT 'committed', ID C_kwDOAsJyMdoAKGNmNjhmZjIxOWRmNWZkMzBiN2E0Yzk5Y2NkODRmMzljYTZjNTc2NTU... The Jenkins Jobs will be shutdown; Testing of this PR must occur again. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: eeprude |
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
…ypes of different signs. Signed-off-by: Ernesto Prudencio <[email protected]>
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: eeprude |
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
Contributor
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
3 similar comments
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
jhux2
changed the title
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
1 similar comment
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
trilinos-autotester
added
the
AT: STALE
Contributor
|
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
…l his help. Signed-off-by: Ernesto Prudencio <[email protected]>
Signed-off-by: Ernesto Prudencio <[email protected]>
Signed-off-by: Ernesto Prudencio <[email protected]>
trilinos-autotester
removed
the
AT: STALE
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: eeprude |
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
Contributor
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
…put parameters. Thanks to Christian Glusa for pointing out that constructor. Signed-off-by: Ernesto Prudencio <[email protected]>
|
Your PR updated files that did not respect package formatting settings. Patchdiff --git a/packages/tpetra/core/src/Tpetra_SolverMap_CrsMatrix_def.hpp b/packages/tpetra/core/src/Tpetra_SolverMap_CrsMatrix_def.hpp
index ec6085c8..e5824eb8 100644
--- a/packages/tpetra/core/src/Tpetra_SolverMap_CrsMatrix_def.hpp
+++ b/packages/tpetra/core/src/Tpetra_SolverMap_CrsMatrix_def.hpp
@@ -140,7 +140,7 @@ SolverMap_CrsMatrix<Scalar, LocalOrdinal, GlobalOrdinal, Node>::operator()(Origi
// Step 5/7: Create new graph
// *****************************************************************
cg_t const* origGraph = dynamic_cast<cg_t const*>(origMatrix->getGraph().get());
- newGraph_ = Teuchos::rcp<cg_t>(new cg_t(*origGraph));
+ newGraph_ = Teuchos::rcp<cg_t>(new cg_t(*origGraph));
newGraph_->resumeFill();
newGraph_->reindexColumns(newColMap_);
newGraph_->fillComplete();More details about our use of clang-format and other tools can be found in the wiki. |
Signed-off-by: Ernesto Prudencio <[email protected]>
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: eeprude |
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
Contributor
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cgcgcg ]! |
Contributor
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
Signed-off-by: Ernesto Prudencio <[email protected]>
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: eeprude |
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
Contributor
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cgcgcg ]! |
Contributor
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/
Motivation
The implementation of the SolverMapTransform using Tpetra follows the same steps used in the EpetraExt/src/transform/ implementation.
The SolverMapTransform is usually used as part of the sequence of 4 transforms, in the following order:
1- SingletonTransform (which will be available in Tpetra soon)
2- SolverMapTransform (this merge request)
3- ReindexTransform (which will be avaiable in Tpetra soon as well, per merge request #14424)
4- RebalanceTransform (which will be available in Trilinoscouplings soon, per merge request #14580)
The Tpetra_Transform.hpp file in this merge request was provided by Ober Curtis (thank you!) He is working on the SingletonTransform. I also want to thank the help, on technical questions of mine, by Ober Curtis, Heidi Thornquist, Michael Wolf, and Samuel Browne.
Related Issues
14280Stakeholder Feedback
Testing
The unit test uses a 17 x 17 matrix provided by Heidi Thornquist (thank you!). If more matrices become available in the future, it will be easy to add more tests using them.
We also made more tests during the development of the Tpetra SolverMapTransform, using other examples provided by Heidi. The tests were made with all number of processors varying from 1 to 8 in a Mac notebook with 8 cores.
All tests mentioned above run fine. Also, they do not trigger any memory leakage warning messages by Trilinos (some messages were triggered for some time, during the development of the Tpetra SolverMapTransform, due to a misuse of Teuchos RCP by the SolverMapTransform code).