Only invoke Kokkos::isfinite on floating point types

Signed-off-by: malphil <[email protected]>

Author: malphil

packages/muelu/src/Graph/MatrixTransformation/MueLu_CutDrop.hpp

@@ -696,8 +696,8 @@ class CutDropFunctor {
         }
       }
 
-      errorEncountered |= !Kokkos::isfinite(x_aij);
-      errorEncountered |= !Kokkos::isfinite(y_aij);
+      errorEncountered |= !is_finite_type_safe(x_aij);
+      errorEncountered |= !is_finite_type_safe(y_aij);
     }
 
     // drop everything to the right of where values stop passing threshold

packages/muelu/src/Graph/MatrixTransformation/MueLu_DistanceLaplacianDropping.hpp

@@ -712,15 +712,15 @@ class DropFunctor {
         auto aiiajj = ATS::magnitude(diag(rlid)) * ATS::magnitude(diag(clid));  // |a_ii|*|a_jj|
         auto aij2   = ATS::magnitude(val) * ATS::magnitude(val);                // |a_ij|^2
 
-        encounteredError |= (!Kokkos::isfinite(aij2) || !Kokkos::isfinite(aiiajj));
+        encounteredError |= (!is_finite_type_safe(aij2) || !is_finite_type_safe(aiiajj));
 
         results(offset + k) = Kokkos::max((aij2 <= eps * eps * aiiajj) ? DROP : KEEP,
                                           results(offset + k));
       } else if constexpr (measure == Misc::SignedRugeStuebenMeasure) {
         auto neg_aij     = -ATS::real(val);
         auto max_neg_aik = eps * ATS::real(diag(rlid));
 
-        encounteredError |= !Kokkos::isfinite(neg_aij) || !Kokkos::isfinite(max_neg_aik);
+        encounteredError |= !is_finite_type_safe(neg_aij) || !is_finite_type_safe(max_neg_aik);
 
         results(offset + k) = Kokkos::max((neg_aij < max_neg_aik) ? DROP : KEEP,
                                           results(offset + k));
@@ -732,7 +732,7 @@ class DropFunctor {
         if (!is_nonpositive)
           aij2 = -aij2;
 
-        encounteredError |= !Kokkos::isfinite(aij2) || !Kokkos::isfinite(aiiajj);
+        encounteredError |= !is_finite_type_safe(aij2) || !is_finite_type_safe(aiiajj);
 
         results(offset + k) = Kokkos::max((aij2 <= eps * eps * aiiajj) ? DROP : KEEP,
                                           results(offset + k));
@@ -859,15 +859,15 @@ class VectorDropFunctor {
         auto aiiajj = ATS::magnitude(diag(brlid)) * ATS::magnitude(diag(bclid));  // |a_ii|*|a_jj|
         auto aij2   = ATS::magnitude(val) * ATS::magnitude(val);                  // |a_ij|^2
 
-        encounteredError |= !Kokkos::isfinite(aij2) || !Kokkos::isfinite(aiiajj);
+        encounteredError |= !is_finite_type_safe(aij2) || !is_finite_type_safe(aiiajj);
 
         results(offset + k) = Kokkos::max((aij2 <= eps * eps * aiiajj) ? DROP : KEEP,
                                           results(offset + k));
       } else if constexpr (measure == Misc::SignedRugeStuebenMeasure) {
         auto neg_aij     = -ATS::real(val);
         auto max_neg_aik = eps * ATS::real(diag(brlid));
 
-        encounteredError |= !Kokkos::isfinite(neg_aij) || !Kokkos::isfinite(max_neg_aik);
+        encounteredError |= !is_finite_type_safe(neg_aij) || !is_finite_type_safe(max_neg_aik);
 
         results(offset + k) = Kokkos::max((neg_aij < max_neg_aik) ? DROP : KEEP,
                                           results(offset + k));
@@ -879,7 +879,7 @@ class VectorDropFunctor {
         if (!is_nonpositive)
           aij2 = -aij2;
 
-        encounteredError |= !Kokkos::isfinite(aij2) || !Kokkos::isfinite(aiiajj);
+        encounteredError |= !is_finite_type_safe(aij2) || !is_finite_type_safe(aiiajj);
 
         results(offset + k) = Kokkos::max((aij2 <= eps * eps * aiiajj) ? DROP : KEEP,
                                           results(offset + k));

packages/muelu/src/Graph/MatrixTransformation/MueLu_DroppingCommon.hpp

@@ -68,6 +68,15 @@ struct DroppingFunctorState<Kokkos::pair<local_ordinal_type, local_ordinal_type>
     , encounteredError(_encounteredError) {}
 };
 
+template <typename T>
+KOKKOS_INLINE_FUNCTION bool is_finite_type_safe(T value) {
+  if constexpr (std::is_floating_point_v<T>) {
+    return Kokkos::isfinite(value);
+  } else {
+    return true;
+  }
+}
+
 namespace Misc {
 
 template <class local_ordinal_type>