Skip to content

Remove obsolete size_in_bytes helpers #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
somethingelseentirely merged 1 commit into from
Jul 23, 2025
Merged

Remove obsolete size_in_bytes helpers #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Added `from_bit` constructor on `BitVectorBuilder` for repeating a single bit.
- `DacsByte` now stores level data as zero-copy `View<[u8]>` values.
- Added `get_bits` methods to `BitVectorData` and `BitVector`.
- Removed deprecated `size_in_bytes` helpers.
- Added `scripts/devtest.sh` and `scripts/preflight.sh` for testing and
verification workflows.
- Simplified CI workflow to run `scripts/preflight.sh` on pull requests.
Expand Down
5 changes: 0 additions & 5 deletions src/bit_vector/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,11 +311,6 @@ impl BitVectorData {
Some(bits)
}

/// Returns the number of bytes required for the old copy-based serialization.
pub fn size_in_bytes(&self) -> usize {
std::mem::size_of::<usize>() * (self.words.len() + 2)
}

/// Serializes the data into a [`Bytes`] buffer.
pub fn to_bytes(&self) -> (usize, Bytes) {
(self.len, self.words.clone().bytes())
Expand Down
17 changes: 0 additions & 17 deletions src/bit_vector/rank9sel/inner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,23 +516,6 @@ impl<const SELECT1: bool, const SELECT0: bool> Rank9SelIndex<SELECT1, SELECT0> {
}
Bytes::from_source(store)
}

/// Returns the number of bytes required for the old copy-based serialization.
pub fn size_in_bytes(&self) -> usize {
let mut mem = std::mem::size_of::<usize>() * 2;
mem += std::mem::size_of::<usize>() * self.block_rank_pairs.len();
mem += std::mem::size_of::<bool>();
if let Some(hints) = &self.select1_hints {
mem += std::mem::size_of::<usize>();
mem += std::mem::size_of::<usize>() * hints.len();
}
mem += std::mem::size_of::<bool>();
if let Some(hints) = &self.select0_hints {
mem += std::mem::size_of::<usize>();
mem += std::mem::size_of::<usize>() * hints.len();
}
mem
}
}

impl<const SELECT1: bool, const SELECT0: bool> crate::bit_vector::BitVectorIndex
Expand Down
15 changes: 1 addition & 14 deletions src/char_sequences/wavelet_matrix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use std::ops::Range;
use anyhow::{anyhow, Result};

use crate::bit_vector::{
Access, BitVector, BitVectorBuilder, BitVectorIndex, NumBits, Rank, Rank9SelIndex, Select,
Access, BitVector, BitVectorBuilder, BitVectorIndex, NumBits, Rank, Select,
};
use crate::int_vectors::{CompactVector, CompactVectorBuilder};
use crate::utils;
Expand Down Expand Up @@ -599,19 +599,6 @@ where
}
}

impl WaveletMatrix<Rank9SelIndex> {
/// Returns the number of bytes required for the old copy-based serialization.
pub fn size_in_bytes(&self) -> usize {
std::mem::size_of::<usize>()
+ self
.layers
.iter()
.map(|l| l.data.size_in_bytes() + l.index.size_in_bytes())
.sum::<usize>()
+ std::mem::size_of::<usize>()
}
}

#[cfg(test)]
mod test {
use super::*;
Expand Down
7 changes: 0 additions & 7 deletions src/int_vectors/compact_vector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,13 +510,6 @@ impl std::fmt::Debug for CompactVector {
}
}

impl CompactVector {
/// Returns the number of bytes required for the old copy-based serialization.
pub fn size_in_bytes(&self) -> usize {
self.chunks.data.size_in_bytes() + std::mem::size_of::<usize>() * 2
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down
18 changes: 0 additions & 18 deletions src/int_vectors/dacs_byte.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,24 +293,6 @@ impl Iterator for Iter<'_> {
}
}

impl DacsByte {
/// Returns the number of bytes required for the old copy-based serialization.
pub fn size_in_bytes(&self) -> usize {
std::mem::size_of::<usize>()
+ self
.data
.iter()
.map(|v| std::mem::size_of::<usize>() + v.len())
.sum::<usize>()
+ std::mem::size_of::<usize>()
+ self
.flags
.iter()
.map(|f| f.data.size_in_bytes() + f.index.size_in_bytes())
.sum::<usize>()
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down