Skip to content

Expose config decoderConfig to enable reuse #9695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2025
Merged

Expose config decoderConfig to enable reuse #9695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25d0ebc
expose config decoderConfig to enable reuse
nopcoder Nov 19, 2025
42c7bd6
update esti workflow docker build action to v6
nopcoder Nov 19, 2025
e6ac9b4
use gitub cache for docker build
nopcoder Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/esti.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,19 +122,17 @@ jobs:
uses: aws-actions/amazon-ecr-login@v2

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3

- name: Build and Push
uses: docker/build-push-action@v5
uses: docker/build-push-action@v6
with:
push: true
tags: ${{ steps.login-ecr.outputs.registry }}/lakefs:${{ needs.gen-code.outputs.tag }}
build-args: VERSION=${{ needs.gen-code.outputs.tag }}
context: .
cache-from: |
type=s3,region=us-east-1,bucket=lakefs-docker-cache,name=lakefs
cache-to: |
type=s3,region=us-east-1,bucket=lakefs-docker-cache,name=lakefs,mode=max
cache-from: type=gha
cache-to: type=gha,mode=max

login-to-amazon-ecr:
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -280,9 +278,9 @@ jobs:
uses: aws-actions/amazon-ecr-login@v2

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
- name: Build and Push to Amazon ECR
uses: docker/build-push-action@v5
uses: docker/build-push-action@v6
with:
push: true
tags: ${{ steps.login-ecr.outputs.registry }}/lakefs-rclone-export:${{ steps.version.outputs.tag }}
Expand Down
4 changes: 2 additions & 2 deletions pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,10 +606,10 @@ func SetDefaults(cfgType string, c Config) {
}

func Unmarshal(c Config) error {
return viper.UnmarshalExact(&c, decoderConfig())
return viper.UnmarshalExact(&c, DecoderConfig())
}

func decoderConfig() viper.DecoderConfigOption {
func DecoderConfig() viper.DecoderConfigOption {
hook := viper.DecodeHook(
mapstructure.ComposeDecodeHookFunc(
DecodeStrings,
Expand Down
Loading