Skip to content

Commit a623471

Browse files
committed
[CR] Use the bencher action directly
Both are about as risky, but by using the action we avoid explicitly adding our GH token to the environment.
1 parent 3665e0e commit a623471

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

.github/workflows/test.yaml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
name: Run Go tests
4343
runs-on: ubuntu-22.04
4444
env:
45-
BENCHER_API_TOKEN: ${{secrets.BENCHER_API_TOKEN}}
45+
BENCHER_API_TOKEN: ${{ secrets.BENCHER_API_TOKEN }}
4646
steps:
4747
- name: Check-out code
4848
uses: actions/checkout@v4
@@ -59,21 +59,18 @@ jobs:
5959
/usr/bin/time -p -o "$time_out" make test
6060
jq -n -R < "$time_out" 'reduce (inputs | split(" ")) as $kv ({}; .[$kv[0]] = {value: ($kv[1] | tonumber)}) | {"test-go-runtime": .}' > "$bench_report"
6161
echo bench_report=$(echo "$bench_report") >> $GITHUB_ENV
62+
- name: Install bencher
6263
- name: Report times to Bencher
6364
# OK to fail here, it's just a bencher report
6465
continue-on-error: true
6566
run: |
6667
ref=${{github.ref_name}}
6768
release_slug=$(uname -s -m | tr '[:upper:]' '[:lower:]' | sed 's/[ _]/-/g')
68-
gh release download --skip-existing -O ./bencher -p '*linux-x86-64' -R bencherdev/bencher v0.5.8
69-
chmod +x ./bencher
70-
./bencher run --adapter json \
69+
bencher run --adapter json \
7170
--file="${bench_report}" \
7271
--project lakefs \
7372
--branch "$ref" \
7473
--testbed "github-${release_slug}"
75-
env:
76-
GH_TOKEN: ${{ github.token }}
7774
- name: What we reported
7875
continue-on-error: true
7976
run: |

0 commit comments

Comments
 (0)