Discussion: use the aquatic InfoHash instead of the wrapper in this package #2
Description
Today, we discussed in a meeting stopping using the InfoHash in this package and directly using the one in the aquatic udp protocol crate.
Here are some projects where we are currently using this type (there might be more):
- https://github.com/torrust/torrust-tracker
- https://github.com/torrust/torrust-index
- https://github.com/torrust/torrust-parse-torrent/blob/a0f7947cf810f7c0f4df93e8819092f902fa2d0a/src/models/info_hash.rs
The aquatic repo has 3:
- https://github.com/greatest-ape/aquatic/blob/master/crates/udp_protocol/src/common.rs#L37
- https://github.com/greatest-ape/aquatic/blob/master/crates/http_protocol/src/common.rs#L19
- https://github.com/greatest-ape/aquatic/blob/master/crates/ws_protocol/src/common.rs#L15
But we are using the one defined in the udp protocol crate
If we finally do it:
- We have to check what is missing or why this wrapper was created (at the beginning, it was now a wrapper; see Refactor: extract duplicate implementation of
InfoHashstruct torrust-index#756). @da2ce7 refactored the tracker to start using the InfoHash from the UDP protocol. It seems nothing is stopping us from using it. - Replace the dependency with this package in the projects listed above with the aquatic one.