Skip to content

One problem with gmodule.lua #137

@zhangty12

Description

@zhangty12

On gmodule.lua : line-337, the reassignment " input = input[1] " seems problematic.

Say, if the module associated with the node is a JoinTable(1), and the input is a singleton {torch.randn(5, 5)}, the program may crash as gmodule would send a tensor torch.randn(5, 5) directly to JoinTable(1):forward(***), instead of a table {torch.randn(5, 5)}.

Therefore, when wrapped up in a gmodule, JoinTable():forward(**) cannot accept singletons as their inputs, and so this contradicts JoinTable's original functionality.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions