Some standalone fixes from new consensus dev branch (#1895)

* Compile libraries in third-party/ with sanitizers as well

This is not a complete solution (with sanitizers, you ideally need a
build-the-world-with-sanitizers approach) but is good enough for abseil
to stop producing memory errors.

* First reset td::Promise and then execute callback

Callback can override promise inplace, so doing it the other way can
reset a newly created PromiseInterface.

* [tontester] Allow to run node under `rr record`

Author: DanShaders

CMakeLists.txt

@@ -99,6 +99,20 @@ if (TON_WERROR_BUILD)
   add_compile_options(-Werror)
 endif()
 
+if (TON_USE_ASAN)
+  add_compile_options(-fsanitize=address)
+  add_link_options(-fsanitize=address)
+  add_definitions(-DTD_USE_ASAN=1)
+endif()
+if (TON_USE_TSAN)
+  add_compile_options(-fsanitize=thread)
+  add_link_options(-fsanitize=thread)
+endif()
+if (TON_USE_UBSAN)
+  add_compile_options(-fsanitize=undefined)
+  add_link_options(-fsanitize=undefined)
+endif()
+
 if (TON_USE_ABSEIL)
   message("Add abseil-cpp")
   function(abseil_scope)
@@ -338,19 +352,6 @@ if (GCC OR CLANG)
   endif()
 endif()
 
-if (TON_USE_ASAN)
-  add_compile_options(-fsanitize=address)
-  add_link_options(-fsanitize=address)
-  add_definitions(-DTD_USE_ASAN=1)
-endif()
-if (TON_USE_TSAN)
-  add_compile_options(-fsanitize=thread)
-  add_link_options(-fsanitize=thread)
-endif()
-if (TON_USE_UBSAN)
-  add_compile_options(-fsanitize=undefined)
-  add_link_options(-fsanitize=undefined)
-endif()
 if (TON_USE_COVERAGE)
   add_cxx_compiler_flag("-fprofile-arcs")
   add_cxx_compiler_flag("-ftest-coverage")

tdactor/td/actor/PromiseFuture.h

@@ -232,31 +232,31 @@ class Promise {
     if (!promise_) {
       return;
     }
-    promise_->set_value(std::move(value));
-    promise_.reset();
+    auto promise = std::exchange(promise_, nullptr);
+    promise->set_value(std::move(value));
   }
   void set_error(Status &&error) {
     if (!promise_) {
       return;
     }
-    promise_->set_error(std::move(error));
-    promise_.reset();
+    auto promise = std::exchange(promise_, nullptr);
+    promise->set_error(std::move(error));
   }
 
   void set_result(Result<T> &&result) {
     if (!promise_) {
       return;
     }
-    promise_->set_result(std::move(result));
-    promise_.reset();
+    auto promise = std::exchange(promise_, nullptr);
+    promise->set_result(std::move(result));
   }
   template <class S>
   void operator()(S &&result) {
     if (!promise_) {
       return;
     }
-    promise_->operator()(std::forward<S>(result));
-    promise_.reset();
+    auto promise = std::exchange(promise_, nullptr);
+    promise->operator()(std::forward<S>(result));
   }
   void reset() {
     promise_.reset();

test/tontester/src/tontester/network.py

@@ -8,7 +8,7 @@
 from enum import IntEnum, auto
 from ipaddress import IPv4Address
 from pathlib import Path
-from typing import cast, final, override
+from typing import Literal, cast, final, override
 
 from pytonlib import TonlibClient, TonlibError  # pyright: ignore[reportMissingTypeStubs]
 
@@ -39,6 +39,9 @@ def _write_model(file: Path, model: TLObject):
     _ = file.write_text(model.to_json())
 
 
+type DebugType = None | Literal["rr"]
+
+
 @final
 class Network:
     class Node(ABC):
@@ -88,6 +91,8 @@ async def _run(
             local_config: ton_api.Engine_validator_config,
             validator_config: ton_api.Validator_config_global | None,
             additional_args: list[str],
+            *,
+            debug: DebugType = None,
         ):
             async def process_watcher():
                 assert self.__process is not None
@@ -121,18 +126,35 @@ async def process_watcher():
             log_path = self._directory / "log"
             l.info(f"Running {self.name} and saving its raw log to {log_path}")
 
-            self.__process = await asyncio.create_subprocess_exec(
-                executable,
+            cmd_flags = [
                 "--global-config",
                 global_config_file,
                 "--local-config",
                 local_config_file,
                 "--db",
                 ".",
                 *additional_args,
-                cwd=self._directory,
-                stderr=asyncio.subprocess.PIPE,
-            )
+            ]
+
+            match debug:
+                case None:
+                    self.__process = await asyncio.create_subprocess_exec(
+                        executable,
+                        *cmd_flags,
+                        cwd=self._directory,
+                        stderr=asyncio.subprocess.PIPE,
+                    )
+                case "rr":
+                    l.info(f"Recording {self.name} with rr")
+                    self.__process = await asyncio.create_subprocess_exec(
+                        "rr",
+                        "record",
+                        executable,
+                        *cmd_flags,
+                        cwd=self._directory,
+                        stderr=asyncio.subprocess.PIPE,
+                    )
+
             assert self.__process.stderr is not None  # to placate pyright
             self.__process_watcher = asyncio.create_task(process_watcher())
 
@@ -146,7 +168,7 @@ def announce_to(self, dht: "DHTNode"):
             self._static_nodes.append(dht)
 
         @abstractmethod
-        async def run(self):
+        async def run(self, *, debug: DebugType = None):
             pass
 
         async def stop(self):
@@ -321,8 +343,8 @@ def signed_address(self):
         return self._signed_address
 
     @override
-    async def run(self):
-        await self._run(self._install.dht_server_exe, self._local_config, None, [])
+    async def run(self, *, debug: DebugType = None):
+        await self._run(self._install.dht_server_exe, self._local_config, None, [], debug=debug)
 
 
 @final
@@ -399,7 +421,7 @@ def validator_key(self):
         return self._validator_key
 
     @override
-    async def run(self):
+    async def run(self, *, debug: DebugType = None):
         zerostate = self._get_or_generate_zerostate()
 
         static_dir = self._directory / "static"
@@ -412,6 +434,7 @@ async def run(self):
             self._local_config,
             zerostate.as_validator_config(),
             ["--initial-sync-delay", "5"],
+            debug=debug,
         )
 
     async def tonlib_client(self) -> TonlibClient: