Add -Werror CI job (#1845)

* Remove commented out directives from top-level CMakeLists

* Use add_compiler_options instead of some weird helper in CMake

* Suppress CMake policy version warning from Abseil

We really should update it.

* Suppress existing warnings

This is not particularly precise as I disabled warnings on file level
(and warning suppression mappings allow specifying function scope) but
is good enough to add -Werror CI job in next commit.

* Add -Werror CI job

Author: DanShaders

.github/workflows/build-ton-linux-x86-64-werror.yml

@@ -0,0 +1,45 @@
+name: Ubuntu TON -Werror build (shared, x86-64)
+
+on: [push, pull_request, workflow_dispatch, workflow_call]
+
+jobs:
+  build:
+    if: github.repository == 'ton-blockchain/ton'
+
+    runs-on: ubuntu-24.04
+
+    steps:
+    - name: Check out repository
+      uses: actions/checkout@v3
+      with:
+        submodules: 'recursive'
+
+    - name: Date Stamp
+      shell: bash
+      id: date-stamp
+      run: |
+        echo "timestamp=$(date -u "+%Y%m%d%H%M_%S")" >> "$GITHUB_OUTPUT"
+
+    - name: Install system libraries
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y build-essential git cmake ninja-build zlib1g-dev libsecp256k1-dev libmicrohttpd-dev libsodium-dev liblz4-dev libjemalloc-dev
+
+    - name: Install Clang 21
+      run: |
+        wget https://apt.llvm.org/llvm.sh
+        chmod +x llvm.sh
+        sudo ./llvm.sh 21 clang
+
+    # TODO: Preserve ccache cache between runs once we get rid of warning suppression mappings.
+
+    - name: Build TON
+      run: |
+        cmake -S . -B build -G Ninja \
+          -DCMAKE_C_COMPILER=clang-21 \
+          -DCMAKE_CXX_COMPILER=clang++-21 \
+          -DCMAKE_BUILD_TYPE=Release \
+          -DTON_USE_JEMALLOC=ON \
+          -DTON_USE_LLD=On \
+          -DTON_WERROR_BUILD=On
+        ninja -C build

CMake/AddCXXCompilerFlag.cmake

@@ -2,7 +2,6 @@ cmake_minimum_required(VERSION 3.16 FATAL_ERROR)
 
 project(TON VERSION 0.5 LANGUAGES C CXX)
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
-#set(OPENSSL_USE_STATIC_LIBS TRUE)
 
 # Define the two required variables before including the source code for watching a git repository.
 set(PRE_CONFIGURE_FILE "git.cc.in")
@@ -35,6 +34,16 @@ set(CMAKE_CXX_EXTENSIONS FALSE)
 
 set(CMAKE_COLOR_DIAGNOSTICS TRUE)
 
+if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+  set(GCC 1)
+elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+  set(CLANG 1)
+elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Intel")
+  set(INTEL 1)
+elseif (NOT MSVC)
+  message(FATAL_ERROR "Compiler isn't supported")
+endif()
+
 #BEGIN internal
 option(BUILD_SHARED_LIBS "Use \"ON\" to build shared libraries instead of static where it's not specified (not recommended)" OFF)
 option(USE_EMSCRIPTEN "Use \"ON\" for config building wasm." OFF)
@@ -77,16 +86,29 @@ if ((ARCHITECTURE MATCHES "arm64") AND (CMAKE_SYSTEM_NAME STREQUAL "Darwin") AND
 endif()
 #END M1 support
 
+if (CLANG AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "20")
+  add_compile_options(--warning-suppression-mappings=${CMAKE_SOURCE_DIR}/suppression_mappings.txt)
+endif()
+
+option(TON_WERROR_BUILD "Use -Werror" OFF)
+
+# If we want to check -Werror build in CI, we want to use it for third party projects as well but we
+# don't want to force our warning options on them.
+if (TON_WERROR_BUILD)
+  add_compile_options(-Werror)
+endif()
+
 if (TON_USE_ABSEIL)
   message("Add abseil-cpp")
-  set(ABSL_PROPAGATE_CXX_STD TRUE)
-  add_subdirectory(third-party/abseil-cpp EXCLUDE_FROM_ALL)
+  function(abseil_scope)
+    set(ABSL_PROPAGATE_CXX_STD TRUE)
+    set(CMAKE_POLICY_VERSION_MINIMUM "3.10")
+    add_subdirectory(third-party/abseil-cpp EXCLUDE_FROM_ALL)
+  endfunction()
+  abseil_scope()
   set(ABSL_FOUND 1)
 endif()
 
-#add_subdirectory(third-party/libcuckoo EXCLUDE_FROM_ALL)
-#add_subdirectory(third-party/junction EXCLUDE_FROM_ALL)
-
 if (WIN32)
   message("Add wingetopt")
   function(wingetopt_scope)
@@ -166,16 +188,6 @@ else()
   message(STATUS "Could NOT find ccache")
 endif()
 
-if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-  set(GCC 1)
-elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  set(CLANG 1)
-elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Intel")
-  set(INTEL 1)
-elseif (NOT MSVC)
-  message(FATAL_ERROR "Compiler isn't supported")
-endif()
-
 include(CheckCXXCompilerFlag)
 
 set(CMAKE_THREAD_PREFER_PTHREAD ON)
@@ -282,33 +294,37 @@ set(TONLIB_COMPILE "0")
   set(TONLIB_COMPILE "1")
 #END tonlib
 
-include(AddCXXCompilerFlag)
 if (MSVC)
-  add_cxx_compiler_flag("/experimental:external /external:anglebrackets /external:W0")
-endif()
-if (NOT MSVC)
-  add_cxx_compiler_flag("-Wall")
-  add_cxx_compiler_flag("-Wextra")
-endif()
-
-add_cxx_compiler_flag("-Wimplicit-fallthrough=2")
-add_cxx_compiler_flag("-Wpointer-arith")
-add_cxx_compiler_flag("-Wcast-qual")
-add_cxx_compiler_flag("-Wsign-compare")
-add_cxx_compiler_flag("-Wduplicated-branches")
-add_cxx_compiler_flag("-Wduplicated-cond")
-add_cxx_compiler_flag("-Walloc-zero")
-add_cxx_compiler_flag("-Wlogical-op")
-add_cxx_compiler_flag("-Wno-tautological-compare")
-add_cxx_compiler_flag("-Wpointer-arith")
-add_cxx_compiler_flag("-Wvla")
-add_cxx_compiler_flag("-Wnon-virtual-dtor")
-add_cxx_compiler_flag("-Wno-unused-parameter")
-add_cxx_compiler_flag("-Wconversion")
-add_cxx_compiler_flag("-Wno-sign-conversion")
-add_cxx_compiler_flag("-Qunused-arguments")
-add_cxx_compiler_flag("-Wno-unused-private-field")
-add_cxx_compiler_flag("-Wno-redundant-move")
+  add_compile_options(/experimental:external /external:anglebrackets /external:W0)
+endif()
+
+if (GCC OR CLANG)
+  add_compile_options(-Wall)
+  add_compile_options(-Wextra)
+
+  add_compile_options(-Wpointer-arith)
+  add_compile_options(-Wcast-qual)
+  add_compile_options(-Wsign-compare)
+  add_compile_options(-Wpointer-arith)
+  add_compile_options(-Wvla)
+  add_compile_options(-Wnon-virtual-dtor)
+  add_compile_options(-Wconversion)
+
+  # TODO: Either justify all of these or remove.
+  add_compile_options(-Wno-tautological-compare)
+  add_compile_options(-Wno-unused-parameter)
+  add_compile_options(-Wno-sign-conversion)
+  add_compile_options(-Wno-unused-private-field)
+  add_compile_options(-Wno-redundant-move)
+
+  if (GCC)
+    add_compile_options(-Wimplicit-fallthrough=2)
+    add_compile_options(-Wduplicated-branches)
+    add_compile_options(-Wduplicated-cond)
+    add_compile_options(-Walloc-zero)
+    add_compile_options(-Wlogical-op)
+  endif()
+endif()
 
 if (GCC OR CLANG)
   if (CMAKE_BUILD_TYPE MATCHES "RelWithDebInfo")
@@ -318,30 +334,19 @@ if (GCC OR CLANG)
   endif()
 endif()
 
-#add_cxx_compiler_flag("-Wno-unused-function")
-#add_cxx_compiler_flag("-Wno-unused-variable")
-#add_cxx_compiler_flag("-Wno-shorten-64-to-32")
-#add_cxx_compiler_flag("-Werror")
-
-#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -isystem /usr/include/c++/v1")
-if (CLANG)
-  #set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -stdlib=libc++")
-endif()
 if (TON_USE_ASAN)
-  add_cxx_compiler_flag("-fsanitize=address")
+  add_compile_options(-fsanitize=address)
+  add_link_options(-fsanitize=address)
   add_definitions(-DTD_USE_ASAN=1)
 endif()
 if (TON_USE_TSAN)
-  add_cxx_compiler_flag("-fsanitize=thread")
+  add_compile_options(-fsanitize=thread)
+  add_link_options(-fsanitize=thread)
 endif()
 if (TON_USE_UBSAN)
-  add_cxx_compiler_flag("-fsanitize=undefined")
+  add_compile_options(-fsanitize=undefined)
+  add_link_options(-fsanitize=undefined)
 endif()
-#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=thread")
-#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address")
-#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined")
-#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=leak")
-#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -finstrument-functions")
 
 #Compilation database
 set(CMAKE_EXPORT_COMPILE_COMMANDS 1)
@@ -451,10 +456,6 @@ target_link_libraries(test-fift PRIVATE fift-lib)
 
 add_executable(test-tdutils test/test-td-main.cpp ${TDUTILS_TEST_SOURCE})
 target_link_libraries(test-tdutils PRIVATE tdutils ${CMAKE_THREAD_LIBS_INIT} memprof ${JEMALLOC_LIBRARIES})
-#target_link_libraries_system(test-tdutils absl::base absl::container absl::hash )
-#target_link_libraries_system(test-tdutils libcuckoo)
-#target_include_directories(test-tdutils PRIVATE SYSTEM ${JUNCTION_ALL_INCLUDE_DIRS})
-#target_link_libraries(test-tdutils PRIVATE ${JUNCTION_ALL_LIBRARIES})
 
 add_executable(test-tdactor test/test-td-main.cpp ${TDACTOR_TEST_SOURCE})
 target_link_libraries(test-tdactor PRIVATE tdactor ${CMAKE_THREAD_LIBS_INIT})
@@ -535,7 +536,7 @@ if (HAS_PARENT)
           ${ED25519_TEST_SOURCE}
           ${TONDB_TEST_SOURCE}
           ${BIGNUM_TEST_SOURCE}
-          ${CELLS_TEST_SOURCE} # ${TONVM_TEST_SOURCE} ${FIFT_TEST_SOURCE} ${TONLIB_ONLINE_TEST_SOURCE}
+          ${CELLS_TEST_SOURCE}
           PARENT_SCOPE)
 endif()
 add_library(all_tests INTERFACE)