Skip to content

build/CI: library -Wno-error escape is too coarse-grained #472

@ppannuto

Description

@ppannuto

libtock-c is fairly pedantic about warnings. When we build external libraries, we relax this by no longer error'ing on warnings (i.e.

# Avoid failing in CI due to warnings in the library.
CPPFLAGS_$(LIBNAME) += -Wno-error
). While this is fine/necessary for the library code itself, it also ignores warnings in our interface code, which in practice lets things like #471 slip through.

We should ideally only allow warnings on actual third-party code, and enforce our stronger checks on our interface code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions