Skip to content

Conversation

@scottaohara
Copy link
Contributor

This PR provides:

Thank you

fixes instances of tripple backticks to single.
fixes typo for “Acknowledgments”
the text on track is meant as a visual text representation of state.

However this text should *not* be exposed to the accessibility api / be included in the accessible name of the control, as it would cause redundant announcements to the change in state that is provided by the control itself (e.g. `aria-checked=“true/false”`

the addition of `aria-hidden=“true”` to the track ensures this text will not be exposed.
@tkent-google
Copy link
Owner

This repository has no license term and no contribution agreement now. So I need to take care of the copyright of your changes.

  • I'll drop your changes of switch.mjs when I move it to Chromium repository, which doesn't allow contribution without agreement signing.
  • I don't want to accept README.md changes because I'm going to copy it to WICG repository. I would have to ask you for copy permission if I accepted the change.

I should have mentioned this in the previous PR #12

@scottaohara
Copy link
Contributor Author

Understood @tkent-google. The readme stuff is just typos anyway, so no worries there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants