[null] Phase 2 & 3: Add comprehensive tests for listeners, delete semantics, and transactions

Author: jamesgpearce

test/unit/core/store/store-nulls.test.ts

@@ -187,3 +187,168 @@ describe('Null with schemas', () => {
     expect(store.getCell('t1', 'r1', 'name')).toBe('Alice');
   });
 });
+
+describe('Null listeners and events', () => {
+  let store: Store;
+
+  beforeEach(() => {
+    store = createStore();
+  });
+
+  test('Cell listener fires when setting to null', () => {
+    let called = 0;
+    let newCell;
+    let oldCell;
+    store.addCellListener('t1', 'r1', 'c1', (_store, _t, _r, _c, nCell, oCell) => {
+      called++;
+      newCell = nCell;
+      oldCell = oCell;
+    });
+
+    store.setCell('t1', 'r1', 'c1', null);
+    expect(called).toBe(1);
+    expect(newCell).toBe(null);
+    expect(oldCell).toBeUndefined();
+  });
+
+  test('Cell listener fires when changing from null', () => {
+    store.setCell('t1', 'r1', 'c1', null);
+    let called = 0;
+    let newCell;
+    let oldCell;
+    store.addCellListener('t1', 'r1', 'c1', (_store, _t, _r, _c, nCell, oCell) => {
+      called++;
+      newCell = nCell;
+      oldCell = oCell;
+    });
+
+    store.setCell('t1', 'r1', 'c1', 'hello');
+    expect(called).toBe(1);
+    expect(newCell).toBe('hello');
+    expect(oldCell).toBe(null);
+  });
+
+  test('Value listener fires when setting to null', () => {
+    let called = 0;
+    let newValue;
+    let oldValue;
+    store.addValueListener('v1', (_store, _v, nValue, oValue) => {
+      called++;
+      newValue = nValue;
+      oldValue = oValue;
+    });
+
+    store.setValue('v1', null);
+    expect(called).toBe(1);
+    expect(newValue).toBe(null);
+    expect(oldValue).toBeUndefined();
+  });
+
+  test('HasCell listener distinguishes null from deleted', () => {
+    let calls: boolean[] = [];
+    store.addHasCellListener('t1', 'r1', 'c1', (_store, _t, _r, _c, hasCell) => {
+      calls.push(hasCell);
+    });
+
+    store.setCell('t1', 'r1', 'c1', null);
+    expect(calls).toEqual([true]);
+
+    store.delCell('t1', 'r1', 'c1');
+    expect(calls).toEqual([true, false]);
+  });
+});
+
+describe('Null vs Delete semantics', () => {
+  let store: Store;
+
+  beforeEach(() => {
+    store = createStore();
+  });
+
+  test('setCell(null) creates a cell, delCell removes it', () => {
+    store.setCell('t1', 'r1', 'c1', null);
+    expect(store.hasCell('t1', 'r1', 'c1')).toBe(true);
+    expect(store.getCell('t1', 'r1', 'c1')).toBe(null);
+    expect(store.getCellIds('t1', 'r1')).toEqual(['c1']);
+
+    store.delCell('t1', 'r1', 'c1');
+    expect(store.hasCell('t1', 'r1', 'c1')).toBe(false);
+    expect(store.getCell('t1', 'r1', 'c1')).toBeUndefined();
+    expect(store.getCellIds('t1', 'r1')).toEqual([]);
+  });
+
+  test('setValue(null) creates a value, delValue removes it', () => {
+    store.setValue('v1', null);
+    expect(store.hasValue('v1')).toBe(true);
+    expect(store.getValue('v1')).toBe(null);
+    expect(store.getValueIds()).toEqual(['v1']);
+
+    store.delValue('v1');
+    expect(store.hasValue('v1')).toBe(false);
+    expect(store.getValue('v1')).toBeUndefined();
+    expect(store.getValueIds()).toEqual([]);
+  });
+
+  test('Null cells appear in iteration', () => {
+    store.setTables({
+      t1: {
+        r1: {c1: 'hello', c2: null, c3: 42},
+      },
+    });
+
+    const cells: [string, any][] = [];
+    store.forEachCell('t1', 'r1', (cellId, cell) => {
+      cells.push([cellId, cell]);
+    });
+
+    expect(cells).toEqual([
+      ['c1', 'hello'],
+      ['c2', null],
+      ['c3', 42],
+    ]);
+  });
+
+  test('Null values appear in iteration', () => {
+    store.setValues({v1: 'test', v2: null, v3: 123});
+
+    const values: [string, any][] = [];
+    store.forEachValue((valueId, value) => {
+      values.push([valueId, value]);
+    });
+
+    expect(values).toEqual([
+      ['v1', 'test'],
+      ['v2', null],
+      ['v3', 123],
+    ]);
+  });
+});
+
+describe('Transactions with null', () => {
+  let store: Store;
+
+  beforeEach(() => {
+    store = createStore();
+  });
+
+  test('Transaction can handle null values', () => {
+    store.setCell('t1', 'r1', 'c1', 'initial');
+
+    store.startTransaction();
+    store.setCell('t1', 'r1', 'c1', null);
+    expect(store.getCell('t1', 'r1', 'c1')).toBe(null);
+    store.finishTransaction();
+
+    expect(store.getCell('t1', 'r1', 'c1')).toBe(null);
+  });
+
+  test('Transaction can commit null values', () => {
+    store.transaction(() => {
+      store.setCell('t1', 'r1', 'c1', null);
+      store.setValue('v1', null);
+    });
+
+    expect(store.getCell('t1', 'r1', 'c1')).toBe(null);
+    expect(store.getValue('v1')).toBe(null);
+  });
+});