system-bridge/logging_test.go at dev · timmo001/system-bridge · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
package main

import (
	"os"
	"path/filepath"
	"runtime"
	"testing"
	"time"

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
	"github.com/timmo001/system-bridge/utils"
)

func TestCleanupOldLogFiles(t *testing.T) {
	logDir := t.TempDir()
	now := time.Date(2026, time.March, 8, 12, 0, 0, 0, time.UTC)

	oldLogPath := filepath.Join(logDir, "2026-02-28.log")
	recentLogPath := filepath.Join(logDir, "2026-03-05.log")
	unmanagedLogPath := filepath.Join(logDir, "system.log")
	malformedLogPath := filepath.Join(logDir, "2026-13-40.log")
	nonLogPath := filepath.Join(logDir, "notes.txt")

	for _, path := range []string{oldLogPath, recentLogPath, unmanagedLogPath, malformedLogPath, nonLogPath} {
		file, err := os.Create(path)
		require.NoError(t, err)
		require.NoError(t, file.Close())
	}

	oldTime := now.Add(-(7*24*time.Hour + time.Minute))
	recentTime := now.Add(-48 * time.Hour)
	unmanagedTime := now.Add(-(14 * 24 * time.Hour))
	require.NoError(t, os.Chtimes(oldLogPath, oldTime, oldTime))
	require.NoError(t, os.Chtimes(recentLogPath, recentTime, recentTime))
	require.NoError(t, os.Chtimes(unmanagedLogPath, unmanagedTime, unmanagedTime))
	require.NoError(t, os.Chtimes(malformedLogPath, unmanagedTime, unmanagedTime))

	require.NoError(t, cleanupOldLogFiles(logDir, now, 7*24*time.Hour))

	assert.NoFileExists(t, oldLogPath)
	assert.FileExists(t, recentLogPath)
	assert.FileExists(t, unmanagedLogPath)
	assert.FileExists(t, malformedLogPath)
	assert.FileExists(t, nonLogPath)
}

func TestMigrateLegacyLogFile(t *testing.T) {
	t.Run("moves legacy log into dated log file", func(t *testing.T) {
		baseDir := t.TempDir()
		configDir := filepath.Join(baseDir, "config")
		logsDir := filepath.Join(baseDir, "logs")

		t.Setenv("SYSTEM_BRIDGE_CONFIG_DIR", configDir)
		t.Setenv("SYSTEM_BRIDGE_LOG_DIR", logsDir)

		legacyLogPath := filepath.Join(configDir, "system-bridge.log")
		require.NoError(t, os.MkdirAll(configDir, 0755))
		require.NoError(t, os.WriteFile(legacyLogPath, []byte("legacy entry\n"), logFilePermissions))

		modTime := time.Date(2026, time.March, 6, 12, 0, 0, 0, time.UTC)
		require.NoError(t, os.Chtimes(legacyLogPath, modTime, modTime))

		require.NoError(t, migrateLegacyLogFile())

		targetLogPath, err := utils.GetLogFilePath(modTime)
		require.NoError(t, err)

		assert.NoFileExists(t, legacyLogPath)
		assert.FileExists(t, targetLogPath)

		content, err := os.ReadFile(targetLogPath)
		require.NoError(t, err)
		assert.Equal(t, "legacy entry\n", string(content))

		if runtime.GOOS != "windows" {
			info, err := os.Stat(targetLogPath)
			require.NoError(t, err)
			assert.Equal(t, logFilePermissions, info.Mode().Perm())

			logsInfo, err := os.Stat(logsDir)
			require.NoError(t, err)
			assert.Equal(t, os.FileMode(0700), logsInfo.Mode().Perm())
		}
	})

	t.Run("appends legacy log into existing dated log file", func(t *testing.T) {
		baseDir := t.TempDir()
		configDir := filepath.Join(baseDir, "config")
		logsDir := filepath.Join(baseDir, "logs")

		t.Setenv("SYSTEM_BRIDGE_CONFIG_DIR", configDir)
		t.Setenv("SYSTEM_BRIDGE_LOG_DIR", logsDir)

		legacyLogPath := filepath.Join(configDir, "system-bridge.log")
		require.NoError(t, os.MkdirAll(configDir, 0755))
		require.NoError(t, os.WriteFile(legacyLogPath, []byte("legacy entry\n"), logFilePermissions))

		modTime := time.Date(2026, time.March, 8, 12, 0, 0, 0, time.UTC)
		require.NoError(t, os.Chtimes(legacyLogPath, modTime, modTime))

		targetLogPath, err := utils.GetLogFilePath(modTime)
		require.NoError(t, err)
		require.NoError(t, os.WriteFile(targetLogPath, []byte("existing entry\n"), logFilePermissions))

		require.NoError(t, migrateLegacyLogFile())

		assert.NoFileExists(t, legacyLogPath)

		content, err := os.ReadFile(targetLogPath)
		require.NoError(t, err)
		assert.Equal(t, "existing entry\nlegacy entry\n", string(content))

		if runtime.GOOS != "windows" {
			info, err := os.Stat(targetLogPath)
			require.NoError(t, err)
			assert.Equal(t, logFilePermissions, info.Mode().Perm())
		}
	})
}

func TestOpenLogFilePermissions(t *testing.T) {
	baseDir := t.TempDir()
	logsDir := filepath.Join(baseDir, "logs")

	t.Setenv("SYSTEM_BRIDGE_LOG_DIR", logsDir)

	logFile, err := openLogFile(time.Date(2026, time.March, 8, 12, 0, 0, 0, time.UTC))
	require.NoError(t, err)
	require.NoError(t, logFile.Close())

	logPath := filepath.Join(logsDir, "2026-03-08.log")
	assert.FileExists(t, logPath)

	if runtime.GOOS == "windows" {
		return
	}

	info, err := os.Stat(logPath)
	require.NoError(t, err)
	assert.Equal(t, logFilePermissions, info.Mode().Perm())

	dirInfo, err := os.Stat(logsDir)
	require.NoError(t, err)
	assert.Equal(t, os.FileMode(0700), dirInfo.Mode().Perm())
}