Fix search input/query search coupling#385
Open
karlshea wants to merge 1 commit into
Open
Conversation
- Fixes query.setSearch(‘value’) not working - Fixes typing to find an action, hitting enter to select it, and the clearing the input to find the next child action
|
@karlshea is attempting to deploy a commit to the Tim's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
This is not stale. Please either remove the stale bot or indicate that you're not looking for contributions to this project so we don't all waste our time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384
It doesn't seem like the local state for the input is necessary. This changes it to be controlled directly by the current search query, and then the onChange updates that query.