Skip to content

Commit cbc96e6

Browse files
authored
config: update the default value of feedback-probability (pingcap#5784) (pingcap#5786)
1 parent de7e54b commit cbc96e6

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

statistics.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,11 +147,7 @@ Three system variables related to automatic update of statistics are as follows:
147147

148148
When the ratio of the number of modified rows to the total number of rows of `tbl` in a table is greater than `tidb_auto_analyze_ratio`, and the current time is between `tidb_auto_analyze_start_time` and `tidb_auto_analyze_end_time`, TiDB executes the `ANALYZE TABLE tbl` statement in the background to automatically update the statistics of this table.
149149

150-
When the query is executed, TiDB collects feedback with the probability of `feedback-probability` and uses it to update the histogram and Count-Min Sketch. You can modify the value of `feedback-probability` in the configuration file. The default value is `0.05`. You can set the value to `0.0` to disable this feature.
151-
152-
> **Note:**
153-
>
154-
> If you set the value of `feedback-probability` to `0` in the configuration file, a failure will occur and an error will be reported. To disable `feedback-probability`, you need to set the value to `0.0`.
150+
Before v5.0, when the query is executed, TiDB collects feedback with the probability of `feedback-probability` and uses it to update the histogram and Count-Min Sketch. **In v5.0, this feature is disabled by default, and it is not recommended to enable this feature.**
155151

156152
### Control `ANALYZE` concurrency
157153

tidb-configuration-file.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,8 +400,8 @@ Configuration items related to performance.
400400
### `feedback-probability`
401401

402402
- The probability that TiDB collects the feedback statistics of each query.
403-
- Default value: `0.05`
404-
- TiDB collects the feedback of each query at the probability of `feedback-probability`, to update statistics.
403+
- Default value: `0`
404+
- This feature is disabled by default, and it is not recommended to enable this feature. If it is enabled, TiDB collects the feedback of each query at the probability of `feedback-probability`, to update statistics.
405405

406406
### `query-feedback-limit`
407407

0 commit comments

Comments
 (0)