fix: cache key in python provider should contain flag key (#3614)

* cache key in python provider should contain flag key

* rename evaluation_context_hash to cache_key

* python: update tests/test_websocket_cache_invalidation.py

---------

Co-authored-by: Thomas Poignant <[email protected]>

Author: kouk

openfeature/providers/python-provider/gofeatureflag_python_provider/provider.py

@@ -70,9 +70,14 @@ def __init__(self, **data):
         websocket.enableTrace(self.options.debug)
         self._ws = websocket.WebSocketApp(
             self._build_websocket_uri(),
+            on_open=self.on_open,
             on_message=self._websocket_message_handler,
         )
 
+    def on_open(self, ws):
+        if self._cache is not None:
+            self._cache.clear()
+
     def initialize(self, evaluation_context: EvaluationContext) -> None:
         """
         initialize is called when the provider is initialized.
@@ -179,11 +184,11 @@ def generic_go_feature_flag_resolver(
                 user=goff_evaluation_context,
                 defaultValue=default_value,
             )
-            evaluation_context_hash = goff_evaluation_context.hash()
+            cache_key = f"{flag_key}:{goff_evaluation_context.hash()}"
             is_from_cache = False
 
-            if evaluation_context_hash in self._cache:
-                response_body = self._cache[evaluation_context_hash]
+            if cache_key in self._cache:
+                response_body = self._cache[cache_key]
                 is_from_cache = True
             else:
                 headers = {"Content-Type": "application/json"}
@@ -240,7 +245,7 @@ def generic_go_feature_flag_resolver(
             )
 
             if response_flag_evaluation.cacheable:
-                self._cache[evaluation_context_hash] = response_body
+                self._cache[cache_key] = response_body
 
             if original_type == int:
                 response_json = json.loads(response_body)

openfeature/providers/python-provider/tests/test_websocket_cache_invalidation.py

@@ -6,7 +6,7 @@
 import requests
 import yaml
 from openfeature import api
-from openfeature.flag_evaluation import FlagEvaluationDetails, Reason
+from openfeature.flag_evaluation import FlagEvaluationDetails, Reason, ErrorCode
 
 from gofeatureflag_python_provider.options import GoFeatureFlagOptions
 from gofeatureflag_python_provider.provider import GoFeatureFlagProvider
@@ -20,7 +20,7 @@ def is_responsive(url):
         response = requests.get(url)
         if response.status_code == 200:
             return True
-    except ConnectionError:
+    except requests.exceptions.ConnectionError:
         return False
 
 
@@ -80,6 +80,15 @@ def test_test_websocket_cache_invalidation(goff):
     )
     want.reason = Reason.CACHED
     assert got == want
+
+    # test https://github.com/thomaspoignant/go-feature-flag/issues/3613
+    got = client.get_boolean_details(
+        flag_key="nonexistent-flag-key",
+        default_value=False,
+        evaluation_context=_default_evaluation_ctx,
+    )
+    assert got.error_code == ErrorCode.FLAG_NOT_FOUND
+
     modify_flag_config()
     got = client.get_boolean_details(
         flag_key=flag_key,