Set samesite to strict for cookies

dormant-user · dormant-user · commit dbf926ec7644 · 2024-02-23T11:24:00.000-06:00
Set title to filename instead of filepath in the UI
Bump version
diff --git a/pystream/__init__.py b/pystream/__init__.py
@@ -2,4 +2,4 @@
 from .main import start  # noqa: F401
 from .models import config, images, secure  # noqa: F401
 
-version = "2.0"
+version = "2.1"
diff --git a/pystream/main.py b/pystream/main.py
@@ -37,7 +37,7 @@ async def redirect_exception_handler(request: Request,
     else:
         response = RedirectResponse(url=exception.location)
     if exception.detail:
-        response.set_cookie("detail", exception.detail.upper())
+        response.set_cookie("detail", exception.detail.upper(), httponly=True, samesite="strict")
     return response
 
 
diff --git a/pystream/routers/auth.py b/pystream/routers/auth.py
@@ -71,7 +71,8 @@ async def login(request: Request) -> JSONResponse:
                          value=config.static.cipher_suite.encrypt(str(auth_payload).encode("utf-8")).decode(),
                          max_age=config.env.session_duration,
                          expires=expiration,
-                         httponly=True)
+                         httponly=True,
+                         samesite="strict")
     if config.env.secure_session:
         cookie_kwargs["secure"] = True
     response.set_cookie(**cookie_kwargs)
diff --git a/pystream/routers/video.py b/pystream/routers/video.py
@@ -95,7 +95,7 @@ async def stream_video(request: Request,
         )
     if pure_path.exists():
         attrs = {
-            "request": request, "video_title": video_path,
+            "request": request, "video_title": pure_path.name,
             "home": config.static.home_endpoint, "logout": config.static.logout_endpoint,
             "path": f"{config.static.streaming_endpoint}?{config.static.query_param}={urlparse.quote(str(pure_path))}"
         }
diff --git a/pystream/templates/land.html b/pystream/templates/land.html
@@ -3,7 +3,7 @@
 <html lang="en">
 <head>
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
-    <title>FastAPI video streaming</title>
+    <title>{{ video_title }}</title>
     <meta property="og:type" content="VideoStreaming">
     <meta name="keywords" content="Python, streaming, fastapi, JavaScript, HTML, CSS">
     <meta name="author" content="Vignesh Rao">

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ async def stream_video(request: Request,`
`95`	`95`	`)`
`96`	`96`	`if pure_path.exists():`
`97`	`97`	`attrs = {`
`98`		`- "request": request, "video_title": video_path,`
	`98`	`+ "request": request, "video_title": pure_path.name,`
`99`	`99`	`"home": config.static.home_endpoint, "logout": config.static.logout_endpoint,`
`100`	`100`	`"path": f"{config.static.streaming_endpoint}?{config.static.query_param}={urlparse.quote(str(pure_path))}"`
`101`	`101`	`}`