Skip to content

Commit fffb59f

Browse files
authored
Merge pull request #513 from jku/fix-naive-datetime-use
repo: Do not use naive datetimes with tuf API
2 parents bd78811 + c83f8c2 commit fffb59f

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

docs/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22

33
## Unreleased
44

5+
## v0.15.1
6+
7+
This point release fixes a bug introduced in 0.15.
8+
9+
* Fixed datetime handling in test-repository (#512): This
10+
is fallout from python-tuf upgrade in 0.15.0 and resulted in
11+
unexpected test-repository action failure
12+
513
## v0.15.0
614

715
* Fixed repository status page HTML rendering (#430)

repo/tuf_on_ci/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "0.15.0"
1+
__version__ = "0.15.1"

repo/tuf_on_ci/client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import os
88
import shutil
99
import sys
10-
from datetime import datetime
10+
from datetime import UTC, datetime
1111
from filecmp import cmp
1212
from tempfile import TemporaryDirectory
1313
from urllib import request
@@ -19,7 +19,7 @@
1919

2020

2121
def expiry_check(dir: str, role: str, timestamp: int):
22-
ref_time = datetime.fromtimestamp(timestamp)
22+
ref_time = datetime.fromtimestamp(timestamp, UTC)
2323
md = Metadata.from_file(os.path.join(dir, f"{role}.json"))
2424
expiry = md.signed.expires
2525
if ref_time > expiry:
@@ -94,7 +94,7 @@ def client(
9494
if time is not None:
9595
# HACK: replace reference time with ours: initial root has been loaded
9696
# already but that is fine: the expiry check only happens during refresh
97-
ref_time = datetime.fromtimestamp(time)
97+
ref_time = datetime.fromtimestamp(time, UTC)
9898
updater._trusted_set.reference_time = ref_time
9999
ref_time_string = f" at reference time {ref_time}"
100100

signer/tuf_on_ci_sign/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
from tuf_on_ci_sign.import_repo import import_repo
33
from tuf_on_ci_sign.sign import sign
44

5-
__version__ = "0.15.0"
5+
__version__ = "0.15.1"
66

77
__all__ = ["delegate", "import_repo", "sign"]

0 commit comments

Comments
 (0)