diff --git a/core/src/main/java/org/testcontainers/containers/GenericContainer.java b/core/src/main/java/org/testcontainers/containers/GenericContainer.java index 4246e620d5b..b0698b42db5 100644 --- a/core/src/main/java/org/testcontainers/containers/GenericContainer.java +++ b/core/src/main/java/org/testcontainers/containers/GenericContainer.java @@ -181,7 +181,7 @@ public class GenericContainer> @Setter(AccessLevel.NONE) private InspectContainerResponse containerInfo; - static WaitStrategy DEFAULT_WAIT_STRATEGY = Wait.defaultWaitStrategy(); + protected static WaitStrategy DEFAULT_WAIT_STRATEGY = Wait.defaultWaitStrategy(); /** * The approach to determine if the container is ready. diff --git a/modules/clickhouse/src/main/java/org/testcontainers/clickhouse/ClickHouseContainer.java b/modules/clickhouse/src/main/java/org/testcontainers/clickhouse/ClickHouseContainer.java index f65177ce68a..74e892c23f7 100644 --- a/modules/clickhouse/src/main/java/org/testcontainers/clickhouse/ClickHouseContainer.java +++ b/modules/clickhouse/src/main/java/org/testcontainers/clickhouse/ClickHouseContainer.java @@ -1,10 +1,8 @@ package org.testcontainers.clickhouse; import org.testcontainers.containers.JdbcDatabaseContainer; -import org.testcontainers.containers.wait.strategy.HttpWaitStrategy; import org.testcontainers.utility.DockerImageName; -import java.time.Duration; import java.util.HashSet; import java.util.Set; @@ -50,11 +48,6 @@ public ClickHouseContainer(final DockerImageName dockerImageName) { dockerImageName.assertCompatibleWith(CLICKHOUSE_IMAGE_NAME); addExposedPorts(HTTP_PORT, NATIVE_PORT); - this.waitStrategy = - new HttpWaitStrategy() - .forStatusCode(200) - .forResponsePredicate("Ok."::equals) - .withStartupTimeout(Duration.ofMinutes(1)); } @Override diff --git a/modules/clickhouse/src/main/java/org/testcontainers/containers/ClickHouseContainer.java b/modules/clickhouse/src/main/java/org/testcontainers/containers/ClickHouseContainer.java index e9f10feb746..77fb8228b5e 100644 --- a/modules/clickhouse/src/main/java/org/testcontainers/containers/ClickHouseContainer.java +++ b/modules/clickhouse/src/main/java/org/testcontainers/containers/ClickHouseContainer.java @@ -1,10 +1,8 @@ package org.testcontainers.containers; -import org.testcontainers.containers.wait.strategy.HttpWaitStrategy; import org.testcontainers.utility.ComparableVersion; import org.testcontainers.utility.DockerImageName; -import java.time.Duration; import java.util.HashSet; import java.util.Set; @@ -65,11 +63,6 @@ public ClickHouseContainer(final DockerImageName dockerImageName) { supportsNewDriver = isNewDriverSupported(dockerImageName); addExposedPorts(HTTP_PORT, NATIVE_PORT); - this.waitStrategy = - new HttpWaitStrategy() - .forStatusCode(200) - .forResponsePredicate("Ok."::equals) - .withStartupTimeout(Duration.ofMinutes(1)); } @Override diff --git a/modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java b/modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java index 713cb81bb62..706ce733272 100644 --- a/modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java +++ b/modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java @@ -173,6 +173,11 @@ public SELF withInitScripts(Iterable initScriptPaths) { @SneakyThrows(InterruptedException.class) @Override protected void waitUntilContainerStarted() { + if (getWaitStrategy() != DEFAULT_WAIT_STRATEGY) { + getWaitStrategy().waitUntilReady(this); + return; + } + logger() .info( "Waiting for database connection to become available at {} using query '{}'", diff --git a/modules/presto/src/main/java/org/testcontainers/containers/PrestoContainer.java b/modules/presto/src/main/java/org/testcontainers/containers/PrestoContainer.java index 946f6a95c6d..127381354be 100644 --- a/modules/presto/src/main/java/org/testcontainers/containers/PrestoContainer.java +++ b/modules/presto/src/main/java/org/testcontainers/containers/PrestoContainer.java @@ -2,13 +2,10 @@ import com.google.common.base.Strings; import org.jetbrains.annotations.NotNull; -import org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy; import org.testcontainers.utility.DockerImageName; import java.sql.Connection; import java.sql.SQLException; -import java.time.Duration; -import java.time.temporal.ChronoUnit; import java.util.Set; /** @@ -47,11 +44,6 @@ public PrestoContainer(final DockerImageName dockerImageName) { super(dockerImageName); dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME); - this.waitStrategy = - new LogMessageWaitStrategy() - .withRegEx(".*======== SERVER STARTED ========.*") - .withStartupTimeout(Duration.of(60, ChronoUnit.SECONDS)); - addExposedPort(PRESTO_PORT); }