JdbcDatabaseContainer ignores set WaitStrategy

[MarcelHeckel]

The JdbcDatabaseContainer overwirtes the method waitUntilContainerStarted() of GenericContainer but does not call super.waitUntilContainerStarted(). So the WaitStrategy set via waitingFor() is not applied. This is really confusing because you wonder why the set WaitStrategy is not called.

Please add super.waitUntilContainerStarted() at the beginning of waitUntilContainerStarted() in JdbcDatabaseContainer. E.g.:

@Override
protected void waitUntilContainerStarted() {
    super.waitUntilContainerStarted();

    logger().info("Waiting for database connection to become available at {} using query '{}'", getJdbcUrl(), getTestQueryString());

    // Repeatedly try and open a connection to the DB and execute a test query
    ....

[bademux]

It is definitely the bug. It should either throw "Unimplemented" exception on JdbcDatabaseContainer#waitingFor or take into account custom wait strategy

Meanwhile I use hackfix below

 public class OracleContainer extends org.testcontainers.containers.OracleContainer {

    public OracleContainer(String dockerImageName) {
        super(dockerImageName);
    }

    @Override
    protected void waitUntilContainerStarted() {
        super.waitUntilContainerStarted();
        WaitStrategy waitStrategy = getWaitStrategy();
        if (waitStrategy != null) {
            waitStrategy.waitUntilReady(this);
        }
    }
}

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

[MarcelHeckel]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

The issue is still valid.

[anderso]

I just spent two hours trying to figure out why waitStrategy is ignored before I found this. And the documentation on this doesn't really explain the relationship between wait strategy and startup strategy BTW, or atleast I don't understand it. I'm guessing startup strategy is applied first and then wait strategy?

[rissabekov-tyro]

Any update on this issue?

[perlun]

I second the opinion of others in this thread. Let's try to get this fixed: #8127